Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21466][table] Add SQL Client default mode value embedded #15255

Closed
wants to merge 5 commits into from

Conversation

zck573693104
Copy link
Contributor

1.Add SQL Client default mode value embedded.
2.Modify sqlClient md,support default mode value embedded.
3.Test sql client default mode embedded.only left a test which uses embedded to verify it still work.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b5443fa (Wed Mar 17 15:53:41 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and sorry for the late response. I left one minor comments.

if (args.length < 1) {
CliOptionsParser.printHelpClient();
return;
final String model;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename model to mode

@wuchong
Copy link
Member

wuchong commented Mar 19, 2021

I have appended a commit to remove useless embedded and also added a test for SqlClient.

Would be great if @fsk119 can have a look again.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jark's help. The added test is amazing.

LGTM.

@zck573693104 zck573693104 marked this pull request as draft March 19, 2021 14:37
@zck573693104 zck573693104 marked this pull request as ready for review March 19, 2021 16:22
@wuchong
Copy link
Member

wuchong commented Mar 20, 2021

Merging...

@wuchong wuchong closed this in 7fad74d Mar 20, 2021
wuchong added a commit that referenced this pull request Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants