Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21006] Fix hbase 1.4 tests on Hadoop 3.x #14770

Closed
wants to merge 2 commits into from

Conversation

rmetzger
Copy link
Contributor

Verifying this change

The issue occurred on the hadoop 3.1.3 nightly profile. Therefore, I'm testing it on my personal CI against that version: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8820&view=results

On the PR CI, we'll verify the change against the normal versions.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 27, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3ec78fe (Fri May 28 08:14:32 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 27, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@rmetzger
Copy link
Contributor Author

There's been a build failure I need to investigate.

@tillrohrmann tillrohrmann changed the title [FLINK-21066] Fix hbase 1.4 tests on Hadoop 3.x [FLINK-21006] Fix hbase 1.4 tests on Hadoop 3.x Jan 27, 2021
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What test failure are you investigating @rmetzger?

The change itself makes sense given that hbase-server does not need Guava or can work together with Flink's Guava version.

Please update the JIRA ticket tag of the commits. I think the JIRA issue is FLINK-21006.

@rmetzger
Copy link
Contributor Author

rmetzger commented Jan 27, 2021

What test failure are you investigating @rmetzger?

The ORC test was failing in the Hadoop 3 profile. Most likely the failure is unrelated to my change and has been caused by configuring the Hadoop 3 profile on azure incorrectly (I forgot the hadoop3-test profile).

I'll update the commit message before merging (once the Hadoop3 azure run has passed)

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants