[FLINK-19773][runtime] Implement ExponentialDelayStrategy #14425

mareksabo · 2020-12-18T12:28:10Z

What is the purpose of the change

This PR add new exponential restart strategy as described in FLINK-19773.

Brief change log

Added restart strategy for exponential backoff.

Verifying this change

This change added unit tests, see PR.
I manually verified that the restart strategy behaves as expected.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes, but only if the strategy is configured / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2020-12-18T12:31:32Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3e9eb80 (Fri May 28 07:00:37 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!
This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-12-18T12:39:26Z

CI report:

d38bb37 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

tillrohrmann

Thanks for creating this PR @mareksabo. It looks very good. I tried the changes out and they work well. The only thing which you need to do is to rerun mvn package -Dgenerate-config-docs -pl flink-docs,flink-core -DskipTests in order to rebuild the configuration documentation. Once this is done and AZP passes, I will merge the PR.

tillrohrmann · 2020-12-23T15:22:29Z

flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java

+ double backoffMultiplier,
+ Time resetBackoffThreshold,
+ double jitterFactor
+ ) {


nit: using the style of this file, the closing parenthesis is usually put in the same line as the last parameter.

tillrohrmann · 2020-12-23T15:24:58Z

.../flink/runtime/executiongraph/failover/flip1/ExponentialDelayRestartBackoffTimeStrategy.java

+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Restart strategy which tries to restart indefinitely number of times with a exponential backoff time in between.


Suggested change

* Restart strategy which tries to restart indefinitely number of times with a exponential backoff time in between.

* Restart strategy which tries to restart indefinitely number of times with an exponential backoff time in between.

tillrohrmann · 2020-12-23T15:40:50Z

...nk/runtime/executiongraph/failover/flip1/ExponentialDelayRestartBackoffTimeStrategyTest.java

+ restartStrategy.notifyFailure(failure);
+ assertCorrectRandomRange(
+ restartStrategy::getBackoffTime,
+ 0L, 1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L);


Shouldn't we set the max backoff time to something like 7 in order to test that we will respect it? At the moment it is set to 9 which means that we won't exceed the max backoff time after three failures if I am not mistaken.

You are right, nice catch!

mareksabo · 2021-01-04T09:23:25Z

@flinkbot run azure

tillrohrmann

Thanks a lot for updating this PR @mareksabo. Merging this PR once AZP gives green light.

…rategy

mareksabo · 2021-01-04T11:15:46Z

Thank you. Although I generated the documentation there was still some information missing in the docs -- I hope I just fixed that.

@flinkbot run azure

tillrohrmann · 2021-01-05T10:46:02Z

Really good work @mareksabo!

rmetzger added the review=description? label Dec 18, 2020

rmetzger added the component=Runtime/Coordination label Dec 18, 2020

tillrohrmann self-assigned this Dec 23, 2020

tillrohrmann approved these changes Dec 23, 2020

View reviewed changes

mareksabo force-pushed the FLINK-19773 branch from 0b24ca0 to b182f84 Compare January 4, 2021 09:00

tillrohrmann approved these changes Jan 4, 2021

View reviewed changes

Marek Sabo added 2 commits January 4, 2021 12:03

[FLINK-19773][runtime] Implement ExponentialDelayRestartBackoffTimeSt…

f60b878

…rategy

Apply spotless formatting

3e9eb80

mareksabo force-pushed the FLINK-19773 branch from b182f84 to 3e9eb80 Compare January 4, 2021 11:04

mareksabo force-pushed the FLINK-19773 branch from d38bb37 to 3e9eb80 Compare January 4, 2021 14:54

tillrohrmann closed this in 13b7b3e Jan 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-19773][runtime] Implement ExponentialDelayStrategy #14425

[FLINK-19773][runtime] Implement ExponentialDelayStrategy #14425

mareksabo commented Dec 18, 2020 •

edited

Loading

flinkbot commented Dec 18, 2020 •

edited

Loading

flinkbot commented Dec 18, 2020 •

edited

Loading

tillrohrmann left a comment

tillrohrmann Dec 23, 2020

tillrohrmann Dec 23, 2020

tillrohrmann Dec 23, 2020

mareksabo Jan 4, 2021

mareksabo commented Jan 4, 2021 •

edited

Loading

tillrohrmann left a comment

mareksabo commented Jan 4, 2021

tillrohrmann commented Jan 5, 2021

	* Restart strategy which tries to restart indefinitely number of times with a exponential backoff time in between.
	* Restart strategy which tries to restart indefinitely number of times with an exponential backoff time in between.

[FLINK-19773][runtime] Implement ExponentialDelayStrategy #14425

[FLINK-19773][runtime] Implement ExponentialDelayStrategy #14425

Conversation

mareksabo commented Dec 18, 2020 • edited Loading

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Dec 18, 2020 • edited Loading

Automated Checks

Review Progress

flinkbot commented Dec 18, 2020 • edited Loading

CI report:

tillrohrmann left a comment

Choose a reason for hiding this comment

tillrohrmann Dec 23, 2020

Choose a reason for hiding this comment

tillrohrmann Dec 23, 2020

Choose a reason for hiding this comment

tillrohrmann Dec 23, 2020

Choose a reason for hiding this comment

mareksabo Jan 4, 2021

Choose a reason for hiding this comment

mareksabo commented Jan 4, 2021 • edited Loading

tillrohrmann left a comment

Choose a reason for hiding this comment

mareksabo commented Jan 4, 2021

tillrohrmann commented Jan 5, 2021

mareksabo commented Dec 18, 2020 •

edited

Loading

flinkbot commented Dec 18, 2020 •

edited

Loading

flinkbot commented Dec 18, 2020 •

edited

Loading

mareksabo commented Jan 4, 2021 •

edited

Loading