Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20372] Update Kafka SQL connector page to mention properties.*… #14276

Merged
merged 5 commits into from
Dec 8, 2020

Conversation

fsk119
Copy link
Member

@fsk119 fsk119 commented Dec 1, 2020

… options

What is the purpose of the change

Add document to use properies to pass kafka config.

Brief change log

image
image

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 1, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1597ca9 (Tue Dec 01 13:01:49 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 1, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

docs/dev/table/connectors/kafka.md Outdated Show resolved Hide resolved
fsk119 and others added 2 commits December 8, 2020 09:58
…ties.security.protocol, properties.sasl.kerberos.service.name
@fsk119
Copy link
Member Author

fsk119 commented Dec 8, 2020

The current page looks:
image
image

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit c7b89af into apache:release-1.12 Dec 8, 2020
wuchong pushed a commit that referenced this pull request Dec 8, 2020
@fsk119 fsk119 deleted the FLINK-20372_1 branch November 22, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants