[FLINK-2429] [streaming] Deprecate the "enableCheckpointing()" method with no interval argument. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with no interval argument.
|
+1 to merge |
|
During some other refactoring, I found that at 3 places, different default values for the default interval are defined ;-) The effective one (5000ms) happens to overwrite the others... |
StephanEwen
added a commit
to StephanEwen/flink
that referenced
this pull request
Nov 20, 2015
… with no interval argument. This closes apache#1382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default checkpoint interval is a bit intransparent. Dropping that method makes the user think about what interval they want to chose.
We could (and should) later add a way that auto-tunes the checkpoint interval, based on the time checkpoints take to complete.