[FLINK-19518] Show proper job duration for running jobs in web ui #13560

rmetzger · 2020-10-08T07:21:18Z

What is the purpose of the change

Caused by FLINK-16866, the web UI is showing the "Duration" of a job as 0 in the overview. Once you open the detail page of a job, you see the correct duration.

Brief change log

Move createDetailsForJob to JobDetails
Call requestJob instead of requestJobStatus to get all the job details in DispatcherJob
Added an integration test.

Verifying this change

added a test
verified manually

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Bugfix

flinkbot · 2020-10-08T07:23:25Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6f5dffb (Thu Oct 08 07:23:24 UTC 2020)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-10-08T07:38:32Z

CI report:

b64dbe9 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

XComp

Thanks for the fix, @rmetzger . I just have a few minor things. Additionally, I did a manual test to check whether the job overview shows the duration. ✅

XComp · 2020-10-09T08:10:15Z

flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java

+ int numTotalTasks = 0;
+
+ for (AccessExecutionJobVertex ejv : job.getVerticesTopologically()) {
+ AccessExecutionVertex[] vertices = ejv.getTaskVertices();


Suggested change

AccessExecutionVertex[] vertices = ejv.getTaskVertices();

AccessExecutionVertex[] taskVertices = ejv.getTaskVertices();

Could we do this renaming to improve the readability since we're dealing with different types of vertices in this code segment?

XComp · 2020-10-09T08:10:47Z

flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java

+ AccessExecutionVertex[] vertices = ejv.getTaskVertices();
+ numTotalTasks += vertices.length;
+
+ for (AccessExecutionVertex vertex : vertices) {


Suggested change

for (AccessExecutionVertex vertex : vertices) {

for (AccessExecutionVertex taskVertex : taskVertices) {

Same here with the vertex variable.

XComp · 2020-10-09T08:39:27Z

flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java

@@ -303,6 +303,55 @@ public void testCancel() throws Exception {
 BlockingInvokable.reset();
 }

+ /**
+ * See FLINK-19518. This test ensures that the /jobs/overview handler shows a duration != 0.
+ *


I know it's a minor thing, but the extra line is not necessary here.

XComp · 2020-10-09T08:40:00Z

flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java

+ BlockingInvokable.latch.await();
+
+ final Duration testTimeout = Duration.ofMinutes(2);
+ final LocalTime deadline = LocalTime.now().plus(testTimeout);


The deadline variable is never used. Are we missing an assert in this test or is this variable obsolete?

XComp · 2020-10-09T08:40:58Z

flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java

+ sender.setInvokableClass(BlockingInvokable.class);
+
+ final JobGraph jobGraph = new JobGraph("Stoppable streaming test job", sender);
+ final JobID jid = jobGraph.getJobID();


jid is never used and can be removed.

rmetzger · 2020-10-14T14:47:24Z

Thanks a lot for your review. I addressed your comments.

rmetzger · 2020-10-14T14:47:32Z

I'll merge it once CI has passed.

rmetzger · 2020-10-15T14:36:13Z

Ci failed. Rebased to latest master.

rmetzger · 2020-10-15T19:30:03Z

CI has passed now. Merging.

rmetzger added the review=description? label Oct 8, 2020

rmetzger added the component=Runtime/WebFrontend label Oct 8, 2020

XComp approved these changes Oct 9, 2020

View reviewed changes

rmetzger force-pushed the FLINK-19518-zero-duration-ui branch from 7ea62ee to 5000a17 Compare October 14, 2020 14:48

rmetzger added 2 commits October 15, 2020 16:35

[FLINK-19518] Show proper job duration for running jobs in web ui

5f1e40b

address PR comments

b64dbe9

rmetzger force-pushed the FLINK-19518-zero-duration-ui branch from 5000a17 to b64dbe9 Compare October 15, 2020 14:35

rmetzger merged commit 9ae7d81 into apache:master Oct 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-19518] Show proper job duration for running jobs in web ui #13560

[FLINK-19518] Show proper job duration for running jobs in web ui #13560

rmetzger commented Oct 8, 2020

flinkbot commented Oct 8, 2020

flinkbot commented Oct 8, 2020 •

edited

Loading

XComp left a comment

XComp Oct 9, 2020

XComp Oct 9, 2020

XComp Oct 9, 2020

XComp Oct 9, 2020

XComp Oct 9, 2020

rmetzger commented Oct 14, 2020

rmetzger commented Oct 14, 2020

rmetzger commented Oct 15, 2020

rmetzger commented Oct 15, 2020

	AccessExecutionVertex[] vertices = ejv.getTaskVertices();
	AccessExecutionVertex[] taskVertices = ejv.getTaskVertices();

	for (AccessExecutionVertex vertex : vertices) {
	for (AccessExecutionVertex taskVertex : taskVertices) {

[FLINK-19518] Show proper job duration for running jobs in web ui #13560

[FLINK-19518] Show proper job duration for running jobs in web ui #13560

Conversation

rmetzger commented Oct 8, 2020

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Oct 8, 2020

Automated Checks

Review Progress

flinkbot commented Oct 8, 2020 • edited Loading

CI report:

XComp left a comment

Choose a reason for hiding this comment

XComp Oct 9, 2020

Choose a reason for hiding this comment

XComp Oct 9, 2020

Choose a reason for hiding this comment

XComp Oct 9, 2020

Choose a reason for hiding this comment

XComp Oct 9, 2020

Choose a reason for hiding this comment

XComp Oct 9, 2020

Choose a reason for hiding this comment

rmetzger commented Oct 14, 2020

rmetzger commented Oct 14, 2020

rmetzger commented Oct 15, 2020

rmetzger commented Oct 15, 2020

flinkbot commented Oct 8, 2020 •

edited

Loading