[FLINK-19000] Forward initialization timestamp from Dispatcher to ExecGraph

[rmetzger]

What is the purpose of the change

FLINK-16866 ("Make job submission non-blocking") introduced a new JobStatus INITIALIZING. However, the ExecutionGraph.stateTimestamps field does not contain the proper timestamp for the INITIALIZING state (it will only be non-zero while the job is INITIALIZING).

This change forwards the timestamp from the Dispatcher to the ExecutionGraph.

Brief change log

• Move timestamp creation out of DispatcherJob into Dispatcher
• Forward timestamp from Dispatcher to ExecutionGraph
• Add a test

Verifying this change

The change includes a new test.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

Not necessary.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 59deb5d (Thu Sep 10 06:47:04 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 59deb5d Azure: FAILURE
• 2283347 UNKNOWN

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[zentol]

The JobDetailsHandler uses the CREATED timestamp for denoting the start of the job; are we sticking with those semantics? (Same with JobResult for calculating runtime, and WebMonitorUtils)

When we adjust the UI we also have to think about a backwards-compatibility path, so that older jobs can be still be displayed in the HistoryServer.

Beyond that, some minor comments.

[zentol]

maybe also check that initializing <= created, to prevent the order from being messed up?

[zentol]

Suggested change

	Deadline.fromNow(Duration.of(10, ChronoUnit.SECONDS)), 5L);
	Deadline.fromNow(Duration.ofSeconds(10), 5L);

[zentol]

I'd move all arguments on a separate line.

[rmetzger]

Thanks a lot for your review. I believe it makes sense to change the semantics and use the INITIALIZING state to calculate the job duration for the web frontend.
I have changed the respective code locations.
Before merging, I'll manually validate that the UI still works.

But first, I'll way for more comments & results from the CI system.

[zentol]

Changes look fine to me.

[rmetzger]

Thanks a lot for the review. I confirmed the UI works. Merging ...