Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18886][python] Support Kafka connectors for Python DataStream … #13161

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

shuiqiangchen
Copy link
Contributor

What is the purpose of the change

Add Kafka connectors for Python DataStream API, supported versions are 0.10.x, 0.11.x and universal.

Brief change log

  • Added FlinkKafkaConsumer010, FlinkKafkaConsumer011 and FlinkKafkaConsuer
  • Added FlinkKafkaProducer010, FlinkKafkaProducer011 and FlinkKafkaProducer

Verifying this change

This pull request has test cases covered by FlinkKafkaTest in test_connectors.py

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? ( not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5195ef9 (Sun Aug 16 06:45:50 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 16, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuiqiangchen Thanks a lot for the PR. The code looks good overall and the test part looks very good. Left some minor comments below.

flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
@shuiqiangchen
Copy link
Contributor Author

@hequn8128 Thank you for your comments, I have updated the pr according to your suggestions, please have a look at it.

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuiqiangchen Thanks a lot for the update. With some minor comments below.

flink-python/pyflink/datastream/connectors.py Show resolved Hide resolved
flink-python/pyflink/datastream/connectors.py Outdated Show resolved Hide resolved
Flink's Kafka connector documentation.
"""

def __init__(self, topic: str, serialization_schema: SerializationSchema,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add kafka_producer_pool_size to the constructor so that the API of FlinkKafkaProducer011 is consistent with FlinkKafkaProducer

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hequn8128 hequn8128 merged commit 3c61dac into apache:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants