-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18886][python] Support Kafka connectors for Python DataStream … #13161
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5195ef9 (Sun Aug 16 06:45:50 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuiqiangchen Thanks a lot for the PR. The code looks good overall and the test part looks very good. Left some minor comments below.
@hequn8128 Thank you for your comments, I have updated the pr according to your suggestions, please have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuiqiangchen Thanks a lot for the update. With some minor comments below.
300e5cc
to
8288a7a
Compare
8288a7a
to
4fd43ca
Compare
Flink's Kafka connector documentation. | ||
""" | ||
|
||
def __init__(self, topic: str, serialization_schema: SerializationSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add kafka_producer_pool_size
to the constructor so that the API of FlinkKafkaProducer011
is consistent with FlinkKafkaProducer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Add Kafka connectors for Python DataStream API, supported versions are 0.10.x, 0.11.x and universal.
Brief change log
Verifying this change
This pull request has test cases covered by FlinkKafkaTest in test_connectors.py
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: ( no)Documentation