-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18728][network] Make initialCredit of RemoteInputChannel final #12994
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a031dfe (Mon Jul 27 08:17:25 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
d164d2a
to
2efaa69
Compare
...time/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
Outdated
Show resolved
Hide resolved
Thanks for the improvement @wsry , the codes look good to me. Only left one comment for further improvement. |
…o BufferManager#unsynchronizedGetAvailableExclusiveBuffers This closes apache#12994.
The filed initialCredit of RemoteInputChannel is set only once and can be accessed by multi threads. This patch makes the filed final and moves the initialization to the constructor of RemoteInputChannel to avoid potential thread safety issues. This closes apache#12994.
…nts from requestMemorySegments() to requestMemorySegments(int) This change makes the interface more flexible and decouples NetworkBufferPool from the concept of exclusive buffer. This close apache#12994.
…nts from requestMemorySegments() to requestMemorySegments(int) This change makes the interface more flexible and decouples NetworkBufferPool from the concept of exclusive buffer. This close apache#12994.
…nts from requestMemorySegments() to requestMemorySegments(int) This change makes the interface more flexible and decouples NetworkBufferPool from the concept of exclusive buffer. This close apache#12994.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and I left some other tiny comments.
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
Show resolved
Hide resolved
...src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
Outdated
Show resolved
Hide resolved
The filed initialCredit of RemoteInputChannel is set only once and can be accessed by multi threads. This patch makes the filed final and moves the initialization to the constructor of RemoteInputChannel to avoid potential thread safety issues. This closes apache#12994.
…nts from requestMemorySegments() to requestMemorySegments(int) This change makes the interface more flexible and decouples NetworkBufferPool from the concept of exclusive buffer. This close apache#12994.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, LGTM!
The failed e2e test should be irrelevant, all tests passed on my private pipeline: https://dev.azure.com/kevin-flink/flink/_build/results?buildId=56&view=results |
…o BufferManager#unsynchronizedGetAvailableExclusiveBuffers This closes #12994.
The filed initialCredit of RemoteInputChannel is set only once and can be accessed by multi threads. This patch makes the filed final and moves the initialization to the constructor of RemoteInputChannel to avoid potential thread safety issues. This closes #12994.
What is the purpose of the change
The filed initialCredit of RemoteInputChannel is set only once and can be accessed by multi threads. This patch makes the filed final and moves the initialization to the constructor of RemoteInputChannel to avoid potential thread safety issues.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation