-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18173][build] Bundle flink-csv and flink-json jars in lib #12527
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3c0eb22 (Mon Jun 08 11:56:32 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @JingsongLi . Could you remove the format jars from $END_TO_END_DIR/flink-sql-client-test/target/sql-jars
, so that we can cover this by e2e tests.
<file> | ||
<source>../flink-formats/flink-csv/target/flink-csv-${project.version}.jar</source> | ||
<outputDirectory>lib/</outputDirectory> | ||
<destName>flink-csv-${project.version}.jar</destName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but shall we use flink-csv-xxx-sql-jar.jar
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can respect module name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove sql-jar
since there is no difference between them so far, and it confuses users? cc @twalthr
7ea5954
to
009cec9
Compare
Considering that flink-avro also relies on Avro and Hadoop, if the user bundled Avro and Hadoop in the user's classloader, this may lead to the problem that the relevant dependency cannot be found in the parent classloader for flink-avro. So flink-avro cannot be bundled into lib. |
00dc5fa
to
892eed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @wuchong for review, merging... |
What is the purpose of the change
The biggest problem for distributions I see is the variety of problems caused by users' lack of format dependency.
These three formats are very small and no third party dependence, and they are widely used by table users. We can just bundle them in "flink/lib/".
It not solve all problems and it is independent of "fat" and "slim". But also improve usability.
Brief change log
Modify flink-dist to bundle jars.
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation