Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18173][build] Bundle flink-csv and flink-json jars in lib #12527

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented Jun 8, 2020

What is the purpose of the change

The biggest problem for distributions I see is the variety of problems caused by users' lack of format dependency.
These three formats are very small and no third party dependence, and they are widely used by table users. We can just bundle them in "flink/lib/".
It not solve all problems and it is independent of "fat" and "slim". But also improve usability.

Brief change log

Modify flink-dist to bundle jars.

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3c0eb22 (Mon Jun 08 11:56:32 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @JingsongLi . Could you remove the format jars from $END_TO_END_DIR/flink-sql-client-test/target/sql-jars, so that we can cover this by e2e tests.

<file>
<source>../flink-formats/flink-csv/target/flink-csv-${project.version}.jar</source>
<outputDirectory>lib/</outputDirectory>
<destName>flink-csv-${project.version}.jar</destName>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but shall we use flink-csv-xxx-sql-jar.jar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can respect module name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove sql-jar since there is no difference between them so far, and it confuses users? cc @twalthr

@JingsongLi JingsongLi force-pushed the bundleFormats branch 6 times, most recently from 7ea5954 to 009cec9 Compare June 12, 2020 06:58
@JingsongLi
Copy link
Contributor Author

Considering that flink-avro also relies on Avro and Hadoop, if the user bundled Avro and Hadoop in the user's classloader, this may lead to the problem that the relevant dependency cannot be found in the parent classloader for flink-avro.

So flink-avro cannot be bundled into lib.

@JingsongLi JingsongLi changed the title [FLINK-18173][build] Bundle flink-csv,flink-json,flink-avro jars in lib [FLINK-18173][build] Bundle flink-csv and flink-json jars in lib Jun 13, 2020
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JingsongLi
Copy link
Contributor Author

Thanks @wuchong for review, merging...

@JingsongLi JingsongLi merged commit 2b2b643 into apache:master Jun 15, 2020
JingsongLi added a commit that referenced this pull request Jun 15, 2020
bigdata-ny pushed a commit to bigdata-ny/flink that referenced this pull request Jun 19, 2020
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
@JingsongLi JingsongLi deleted the bundleFormats branch November 5, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants