[FLINK-17230] Fix incorrect returned address of Endpoint for external Service of ClusterIP type #12277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
At the moment, when external Service is set to ClusterIP, we return
${internal-service-name} + "." + nameSpace
as the address of the Endpoint, which could be problematic since we don't create the internal service in ZooKeeper based HA setups. According to FLINK-16602, we always use external Service for rest communication so that this PR returns${external-service-name} + "." + nameSpace
as Endpoint's address instead.Brief change log
Verifying this change
This change hardens
Fabric8FlinkKubeClientTest#testClusterIPService
to add a test branch for Endpoint's address.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation