Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16097] Translate "SQL Client" page of "Table API & SQL" into Chinese #11961

Merged
merged 2 commits into from
May 9, 2020
Merged

[FLINK-16097] Translate "SQL Client" page of "Table API & SQL" into Chinese #11961

merged 2 commits into from
May 9, 2020

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented Apr 30, 2020

What is the purpose of the change

This pull request translates "SQL Client" page into Chinese.

Verifying this change

This change is a docs work without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@XBaith
Copy link
Contributor Author

XBaith commented Apr 30, 2020

Hi, @klion26. Thanks for your advises.
Could you please check this again?

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 66891d0 (Thu Apr 30 12:44:19 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 30, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XBaith thanks for the contribution, I left some comments.

docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
docs/dev/table/sqlClient.zh.md Outdated Show resolved Hide resolved
@XBaith
Copy link
Contributor Author

XBaith commented May 5, 2020

@XBaith thanks for the contribution, I left some comments.

Thank you so much, Qiu Congxian (@klion26)! I have revised the translations base on your opinions.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XBaith thanks for addressing my comments, I only have one little comment about adding the ""
ping @wuchong

docs/dev/table/sqlClient.zh.md Show resolved Hide resolved
@XBaith
Copy link
Contributor Author

XBaith commented May 9, 2020

@XBaith thanks for addressing my comments, I only have one little comment about adding the ""
ping @wuchong

这个修改是根据官方要求的翻译规范的。
如果需要我可以修改一下

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution @XBaith and the reviewing @klion26 .

@wuchong wuchong merged commit fb7ae52 into apache:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants