Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17255][python] Add HBase connector descriptor support in PyFlink. #11955

Merged
merged 1 commit into from
May 6, 2020

Conversation

shuiqiangchen
Copy link
Contributor

What is the purpose of the change

HBase connector descriptor is already supported since 1.10.0 at Java side. We should also support it in PyFlink.

Brief change log

  • add HBase connector descriptor methods corresponding to java side in descriptors.py
  • add HBaseDescriptorTests in test_descriptors.py
  • add HBase connector usage documentation in connect.md

Verifying this change

This change added tests and can be verified as follows:

  • added HBaseDescriptorTests in test_descriptors.py

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 66b1693 (Thu Apr 30 06:20:30 UTC 2020)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 30, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dianfu
Copy link
Contributor

dianfu commented May 1, 2020

@flinkbot run azure

@dianfu
Copy link
Contributor

dianfu commented May 1, 2020

@zentol Do you know why the CI was not triggered even manually triggered with @flinkbot run azure?

@dianfu
Copy link
Contributor

dianfu commented May 1, 2020

@flinkbot run azure

1 similar comment
@shuiqiangchen
Copy link
Contributor Author

@flinkbot run azure

@dianfu
Copy link
Contributor

dianfu commented May 6, 2020

@shuiqiangchen Thanks for the PR. LGTM. Merging...

@dianfu dianfu merged commit a8cee7b into apache:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants