[FLINK-2703] Prepare Flink for using it with Logback. #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,9 @@ under the License. | |||
|
|
|||
| <includes> | |||
| <include>org.apache.flink:flink-python</include> | |||
| <include>org.apache.flink:flink-python</include> | |||
There was a problem hiding this comment.
Accidental line duplication?
There was a problem hiding this comment.
Oops... Yes. I'll remove that again
|
Nice addition, looks good to me! +1 to merge this |
|
Thank you for the review. I'm merging this PR |
aljoscha
pushed a commit
to aljoscha/flink
that referenced
this pull request
Oct 2, 2015
sachingoel0101
pushed a commit
to sachingoel0101/flink
that referenced
this pull request
Oct 8, 2015
lofifnc
pushed a commit
to lofifnc/flink
that referenced
this pull request
Oct 8, 2015
cfmcgrady
pushed a commit
to cfmcgrady/flink
that referenced
this pull request
Oct 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was talking to a user recently who asked for using Logback instead of Log4j.
This pull request is adding a section in the "Best practices" page which describes how to use Logback for running Flink locally from the IDE and on a cluster.
I also needed to change the pom's of
flink-dist: They are now placing log4j and slf4j-log4j as separate jars into the lib/ folder (instead of packing them into the fat jar).