Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17339][table] Change default planner to blink #11910

Closed
wants to merge 9 commits into from

Conversation

KurtYoung
Copy link
Contributor

What is the purpose of the change

Change the default planner to blink, and update test cases caused by this.

Verifying this change

This change is already covered by existing tests

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1bb8ea4 (Sat Apr 25 13:40:03 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 25, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KurtYoung Thanks for the contribution, I left some minor comments.
TpcdsTestProgram, BatchSQLTestProgram is missing.

@KurtYoung
Copy link
Contributor Author

@libenchao Thanks for the reviewing, I've addressed your comments.

@libenchao
Copy link
Member

@KurtYoung Thanks for addressing my comments. It seems that you didn't notice

TpcdsTestProgram and BatchSQLTestProgram is missing

in the comment.

@KurtYoung
Copy link
Contributor Author

@libenchao I've noticed them. I think it's ok to use blink planner explicitly

@libenchao
Copy link
Member

@KurtYoung Thanks for the explain, the changes LGTM now.
BTW, we should also update the documentation about this change. (I think you must be aware of this, and planned to do it in another issue. Just a reminder)

@KurtYoung
Copy link
Contributor Author

Yes, it's FLINK-17340

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KurtYoung , looks good to me overall. Left some comments.

@KurtYoung KurtYoung closed this in f0a4b09 Apr 26, 2020
@KurtYoung KurtYoung deleted the default-planner branch April 26, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants