-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17339][table] Change default planner to blink #11910
Conversation
… planner changing.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 1bb8ea4 (Sat Apr 25 13:40:03 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KurtYoung Thanks for the contribution, I left some minor comments.
TpcdsTestProgram
, BatchSQLTestProgram
is missing.
...k-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
Show resolved
Hide resolved
...table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
Show resolved
Hide resolved
@libenchao Thanks for the reviewing, I've addressed your comments. |
@KurtYoung Thanks for addressing my comments. It seems that you didn't notice
in the comment. |
@libenchao I've noticed them. I think it's ok to use blink planner explicitly |
@KurtYoung Thanks for the explain, the changes LGTM now. |
Yes, it's FLINK-17340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KurtYoung , looks good to me overall. Left some comments.
What is the purpose of the change
Change the default planner to blink, and update test cases caused by this.
Verifying this change
This change is already covered by existing tests