-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI #11334
Conversation
…ontains Chinese String in SQL CLI
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3872cef (Fri Mar 06 15:55:49 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
...ink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
Outdated
Show resolved
Hide resolved
…ontains Chinese String in SQL CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, the result looks good locally now.
...e/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java
Outdated
Show resolved
Hide resolved
...e/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java
Outdated
Show resolved
Hide resolved
...e/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliUtils.java
Outdated
Show resolved
Hide resolved
...ink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
Outdated
Show resolved
Hide resolved
…contains Chinese string in SQL CLI (apache#11334) * [FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI * [FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI * address comment * add license and unit tests * revert pom header format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aljoscha @KurtYoung ,thanks very much for your explanation .
I create a PR to hot fix this, please help to review this.
What is the purpose of the change
Brief change log
Verifying this change
Add test in CliTableauResultViewTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation