-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15933][catalog][doc] Update content of how generic table schem… #11029
Conversation
…a is stored in hive via HiveCatalog
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 64fccf2 (Thu Feb 06 08:25:26 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@bowenli86 @JingsongLi Let me know if you think the change makes sense. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you
- update the example at https://ci.apache.org/projects/flink/flink-docs-master/dev/table/hive/hive_catalog.html#step-4-start-sql-client-and-create-a-kafka-table-with-flink-sql-ddl ? specifically the console output part of "DESCRIBE mykafka;"
- update xxx.zh.md?
@bowenli86 We don't have any console output for "DESCRIBE mykafka;" now. I'll add the output for "DESCRIBE FORMATTED mykafka;" instead. |
@bowenli86 Docs updated. Please have another look. Thanks. |
why we don't have any console output for describing a table? Seems like a bug? |
Because we have changed to store the generic table schema as properties. So from Hive perspective, the table doesn't have any columns. |
my bad, I thought it's a flink cli... LGTM, merging |
…a is stored in hive via HiveCatalog closes #11029
…a is stored in hive via HiveCatalog closes apache#11029
…a is stored in hive via HiveCatalog
What is the purpose of the change
Update docs as a result of FLINK-15858.
Brief change log
Supported Types
to HiveCatalog page since it's more closely relatedTIMESTAMP
typeVerifying this change
NA
Does this pull request potentially affect one of the following parts:
NA
Documentation
NA