Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15933][catalog][doc] Update content of how generic table schem… #11029

Closed
wants to merge 3 commits into from

Conversation

lirui-apache
Copy link
Contributor

…a is stored in hive via HiveCatalog

What is the purpose of the change

Update docs as a result of FLINK-15858.

Brief change log

  • Add descriptions about hive v.s. generic table
  • Move Supported Types to HiveCatalog page since it's more closely related
  • Minor updates to the support of TIMESTAMP type

Verifying this change

NA

Does this pull request potentially affect one of the following parts:

NA

Documentation

NA

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 6, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 64fccf2 (Thu Feb 06 08:25:26 UTC 2020)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@lirui-apache
Copy link
Contributor Author

@bowenli86 @JingsongLi Let me know if you think the change makes sense. Thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 6, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@bowenli86 bowenli86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you

  1. update the example at https://ci.apache.org/projects/flink/flink-docs-master/dev/table/hive/hive_catalog.html#step-4-start-sql-client-and-create-a-kafka-table-with-flink-sql-ddl ? specifically the console output part of "DESCRIBE mykafka;"
  2. update xxx.zh.md?

@lirui-apache
Copy link
Contributor Author

@bowenli86 We don't have any console output for "DESCRIBE mykafka;" now. I'll add the output for "DESCRIBE FORMATTED mykafka;" instead.

@lirui-apache
Copy link
Contributor Author

@bowenli86 Docs updated. Please have another look. Thanks.

@bowenli86
Copy link
Member

bowenli86 commented Feb 10, 2020

@bowenli86 We don't have any console output for "DESCRIBE mykafka;" now. I'll add the output for "DESCRIBE FORMATTED mykafka;" instead.

why we don't have any console output for describing a table? Seems like a bug?

@lirui-apache
Copy link
Contributor Author

@bowenli86 We don't have any console output for "DESCRIBE mykafka;" now. I'll add the output for "DESCRIBE FORMATTED mykafka;" instead.

why we don't have any console output for describing a table? Seems like a bug?

Because we have changed to store the generic table schema as properties. So from Hive perspective, the table doesn't have any columns.

@bowenli86
Copy link
Member

@bowenli86 We don't have any console output for "DESCRIBE mykafka;" now. I'll add the output for "DESCRIBE FORMATTED mykafka;" instead.

why we don't have any console output for describing a table? Seems like a bug?

Because we have changed to store the generic table schema as properties. So from Hive perspective, the table doesn't have any columns.

my bad, I thought it's a flink cli...

LGTM, merging

@bowenli86 bowenli86 closed this in 3766daa Feb 11, 2020
bowenli86 pushed a commit that referenced this pull request Feb 11, 2020
@lirui-apache lirui-apache deleted the FLINK-15933 branch February 12, 2020 01:04
JTaky pushed a commit to JTaky/flink that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants