[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient #10965
Conversation
This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level from info to debug.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b9cfbe9 (Wed Jan 29 17:05:19 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
The changes make sense to me. When the user want to dig into or find the root cause, they could set the log level to |
|
Thanks for the review @wangyang0918. Shall we try to use |
| break; | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onClose(KubernetesClientException e) { | ||
| LOG.error("Pods watcher onClose", e); | ||
| LOG.debug("The pods watcher is closing.", e); |
There was a problem hiding this comment.
Not in the scope of this PR but why is it acceptable to omit error handling? If the connection attempts of the websocket are exhausted, we will stop watching for changes.
There was a problem hiding this comment.
Maybe @wangyang0918 can tell us why this is ok. If not then this should be properly forwarded and finally handled. This could then be another subtask of https://issues.apache.org/jira/browse/FLINK-15788.
There was a problem hiding this comment.
Then let's leave this statement on ERROR for the time being.
There was a problem hiding this comment.
@GJL It is a very nice catch. Currently, i do not think the watcher will be stopped even some exception occurs. Since the default value of watchReconnectLimit is -1. That means the WatchConnectionManager will always reconnect. The only one case is the WatchConnectionManager#close() by expected.
However, if the watchReconnectLimit is configured by users via java properties or environment, the watch may be stopped and all the changes will not be processed properly. I will create a new ticket to track this. A fatal exception will be thrown when the watcher is closed.
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/FLINK-15836
The ticket has been created.
|
@tillrohrmann Using the |
|
Thanks for the review @wangyang0918 and @GJL. Merging this PR now. |
This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level from info to debug. This closes #10965.
This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level from info to debug. This closes apache#10965.
What is the purpose of the change
This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level
from info to debug.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation