Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15697][docs] Move python options from general configuration page to table config options page #10957

Closed
wants to merge 1 commit into from

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

Move python options from general configuration page to table config options page. Those options can not be set from flink-conf.yaml and should not be in the general page.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys
Copy link
Contributor Author

cc @aljoscha @sunjincheng121

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4d6b2d5 (Wed Jan 29 08:25:00 UTC 2020)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 29, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@StephanEwen
Copy link
Contributor

Looks good, +1

Will merge this as part of the docs rework.

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 30, 2020
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 31, 2020
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 31, 2020
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 3, 2020
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 3, 2020
@asfgit asfgit closed this in afd88a3 Feb 3, 2020
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 3, 2020
JTaky pushed a commit to JTaky/flink that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants