Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14907] [filesystem] Make Azure Storage Key configurable via Environment Variable #10376

Closed
wants to merge 2 commits into from

Conversation

knaufk
Copy link
Contributor

@knaufk knaufk commented Dec 2, 2019

What is the purpose of the change

Make Azure Storage Key configurable via Environment Variable

Brief change log

  • update documentation on credential configuration for ABS
  • add EnvironmentVariableKeyProvider for Azure Blob Storage

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • build Flink
  • set Flink configuration as outlined in documentation
  • set AZURE_STORAGE_KEY environment variable
  • use wasbs:https:// for checkpoints or as file input for a testing job
  • (test_azure_fs.sh can be modified to test this)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs, JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 2, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ab1dcfb (Mon Dec 02 06:34:53 UTC 2019)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 2, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@StephanEwen
Copy link
Contributor

Looks good, +1 to merge.

Nit: I think the optional wrapping here is a bit overkill. For such a local variable, just checking for null seems even easier.

@knaufk knaufk force-pushed the FLINK-14907 branch 2 times, most recently from 4909f07 to 52f8472 Compare December 6, 2019 13:56
@knaufk
Copy link
Contributor Author

knaufk commented Dec 6, 2019

@StephanEwen Thank you for the review. I have addressed your comment and fixed some typos in the documentation.

It would help, if we can still merge this before the release branch is cut.

@StephanEwen
Copy link
Contributor

Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 7, 2019
…ure Blob Storage

Also updates the documentation on credential configuration for ABS

This closes apache#10376
@asfgit asfgit closed this in 56cd59f Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants