Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14593][client] Port ClusterClient to asynchronous interface version #10069

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Nov 1, 2019

What is the purpose of the change

Port ClusterClient to asynchronous interface version

Brief change log

  1. Port ClusterClient to interface
  2. Port cancel/cancelWithSavepoint/stopWithSavepoint/getAccumulators to asynchronous version
  3. Introduce a settable TestingClusterClient and remove FakeClusterClient
  4. Adjust related code.

Verifying this change

This change is a refactor and covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@tisonkun tisonkun requested a review from kl0u November 1, 2019 16:36
@tisonkun tisonkun changed the title [FLINK-FLINK-14593][client] Port ClusterClient to asynchronous interface version [FLINK-14593][client] Port ClusterClient to asynchronous interface version Nov 1, 2019
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 1, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9e4ab5e (Wed Dec 04 15:01:46 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 1, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@tisonkun
Copy link
Member Author

tisonkun commented Nov 5, 2019

Hi @kl0u @aljoscha could you take a look at this?

Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @tisonkun , I had some comments that you can find here. Let me know what you think.

@tisonkun
Copy link
Member Author

tisonkun commented Nov 6, 2019

Thanks for your review @kl0u ! I've updated the pull request.

Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changes look good @tisonkun ! Please let it run once more on Travis and then feel free to merge.

@tisonkun
Copy link
Member Author

tisonkun commented Nov 7, 2019

@flinkbot run travis

@tisonkun
Copy link
Member Author

tisonkun commented Nov 7, 2019

Thanks for your review @kl0u !

@tisonkun tisonkun merged commit d938c19 into apache:master Nov 8, 2019
@tisonkun tisonkun deleted the cluster-client-interface branch November 8, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants