-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14593][client] Port ClusterClient to asynchronous interface version #10069
Conversation
5065569
to
7221802
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9e4ab5e (Wed Dec 04 15:01:46 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @tisonkun , I had some comments that you can find here. Let me know what you think.
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
Outdated
Show resolved
Hide resolved
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
Outdated
Show resolved
Hide resolved
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
Outdated
Show resolved
Hide resolved
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
Outdated
Show resolved
Hide resolved
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
Outdated
Show resolved
Hide resolved
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
Outdated
Show resolved
Hide resolved
flink-clients/src/test/java/org/apache/flink/client/cli/util/MockedCliFrontend.java
Show resolved
Hide resolved
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopWithSavepointTest.java
Outdated
Show resolved
Hide resolved
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
Outdated
Show resolved
Hide resolved
Thanks for your review @kl0u ! I've updated the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that changes look good @tisonkun ! Please let it run once more on Travis and then feel free to merge.
@flinkbot run travis |
Thanks for your review @kl0u ! |
What is the purpose of the change
Port ClusterClient to asynchronous interface version
Brief change log
cancel
/cancelWithSavepoint
/stopWithSavepoint
/getAccumulators
to asynchronous versionTestingClusterClient
and removeFakeClusterClient
Verifying this change
This change is a refactor and covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation