remove TODO Auto-generated method stub #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xurror thanks for this first contribution! The build failed just because of FINERACT-800. Could you rebase this when #657 has been merged? |
|
Will merge this now. Thanks for your contribution @xurror . Please, Pick other issues and try to fix them. Ask for help on mailing list if you get into problems. |
|
When I try rebasing, I notice alot of conflicting commits.
When I try adding the incoming conflicting commits, the build fails but when I skip the conflicts, I fall 9 commits behind the upstream develop but all builds go well.
Is this a normal behaviour?
On Mon, 25 Nov 2019 at 09:00, Awasum Yannick <[email protected]<mailto:[email protected]>> wrote:
Merged #655<#655> into develop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#655?email_source=notifications&email_token=AK5B5DH2KUXLX3YPLT3DY53QVOA3JA5CNFSM4JRD4NNKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVCAVEGY#event-2827047451>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5B5DC66QJOJC7UXQV5OZLQVOA3JANCNFSM4JRD4NNA>.
|
|
This is already merged...just go back to your develop branch and pull from upstream develop. |
|
Ok thanks
On Mon, 25 Nov 2019 at 13:08, Awasum Yannick <[email protected]<mailto:[email protected]>> wrote:
This is already merged...just go back to your develop branch and pull from upstream develop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#655?email_source=notifications&email_token=AK5B5DEUCLLEJRDKEEZCNDTQVO52ZA5CNFSM4JRD4NNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCFPKQ#issuecomment-558127018>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5B5DB5THNXKDBTMF4PNELQVO52ZANCNFSM4JRD4NNA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed an already implemented trailing TODO task from the code base
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide