JdbcSupport added utility function for getting localDateTime after considering timezone of tenant

[mohitsinha]

JdbcSupport added utility function for getting localDateTime after considering timezone of tenant
This utility function will be useful in many cases where someone needs to retrieve @TeMPOraL(TemporalType.TIMESTAMP) for eg: created_date

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

• Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

• API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.

• Integration tests have been created/updated for verifying the changes made.

• All Integrations tests are passing with the new commits.

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

[ippezshelby]

@mohitsinha , Is it possible to implement this too?
Background
Currently the today variable in getLocalDateOfTenant() method takes the current date of the server. However, we would like to have a custom current date by creating a new column in m_office called current_working_date and this value queried from the database and set as today. It is then changed or set to the next working date when closing day (Accounting Closure)

So if as of today the current_working_date is say '18-04-2019' though the date today is 23-04-2019, we want all system posted transactions and manual transactions to have '18-04-2019' as transaction date. At the end of the day, during Accounting Closure, the next working date (19-04-2019' is set.

How do i modify DateUtils.getLocalDateOfTenant() to achieve this?

[mohitsinha]

@Ippezrobert
I think it's possible, is this a new feature that is desired. I don't think it has anything to do with my commit.

You may want to look at the class FineractPlatformTenant and read values from database and store it there if you want to store current working day for a tenant, rather than for each offices.

[ippezshelby]

@mohitsinha , i was hoping you can help to extend that. Its should be for each office not at tenant level because there may be a day which is not a working day in one office but a working day in another office. Am hoping this value to be stored in m_table. Its just a new enhancement that is custom to us and may also apply to other users in the community.

Something like this

[mohitsinha]

@Ippezrobert I don't know if I understood the requirement correctly.
You need to post transactions on 23-04 as transactions done on 18-04 because the last working day of the office was 18-04.
Fineract supports back date transactions very well which you can use directly. Hence you can pass the transaction date/ loan creation date/ client creation date to 18-04 even on 23-04 if you are able to keep track of the last working date of the office.

Currently, if the functionality to set the last working date has to be added on Mifos, it will be a big feature as a lot of things may be needed like Crons to update date, test cases etc.

[ippezshelby]

The manually triggered trasactions are okay as the user selects the date from the datepicker and can slect the current working date (2019-04-08) as in the above example but now the dilema is in automatice system postings like interest posting, standing order processing and all system triggered transactions in which it selects the date from

fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java

Line 63 in 67ba10f

public static LocalDate getLocalDateOfTenant() {

I guess the returned variable today is the one the system uses as transaction date for system triggered transactions, now if so i would like the system to assign the value of this to be 2019-04-08 to the returned variable today as queried from database

[awasum]

@Ippezrobert and @mohitsinha , What is the status of this?

Should the additional feature request go into another issue? Maybe create a new issue to track this feature.
@Ippezrobert will you be able to review and merge this?

[mohitsinha]

@awasum @Ippezrobert I think the new feature requested is outside the scope of this fix. It will be a bigger code fix and should be handled separately.

[awasum]

@Ippezrobert Will u be willing to create a new Issue on JIRA to address the new request you made?

[awasum]

@mohitsinha Have u subscribed to the fineract dev list?

[mohitsinha]

Yes

[awasum]

@mohitsinha Make sure you have an account on Fineract JIRA: https://issues.apache.org/jira/projects/FINERACT/summary

So you create issues, assign them to yourself and discuss ideas on the mailing list before sending in PRs...

[mohitsinha]

I have an account. I can create issues, but I can't assign myself to it (maybe it's because I am not part of the Apache Software Foundation).

I thought that, small changes like this don't need a JIRA id. Whenever, I make a big change, I create a ticket and commit my code with the message starting with the JIRA id.

[awasum]

Great, You are right. I was just making sure.

[ippezshelby]

Sure i will do that this coming week.

…

On Sun, Jul 7, 2019 at 11:32 PM Awasum Yannick ***@***.***> wrote: Great, You are right. I was just making sure. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#563?email_source=notifications&email_token=ADEEM4RLV2JWOBQYJRKGKL3P6JHFVA5CNFSM4HHZDT4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLSSNQ#issuecomment-509028662>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADEEM4VSL23DOX2HVIO7R6LP6JHFVANCNFSM4HHZDT4A> .

-- Ippez Roberts Founder/C.E.O - Swift3 Technologies (U) Ltd "Redefining Next Generation I/O Systems" P.O.Box 155, Moyo UGANDA. Tel: +256777421862/775686538 Skype ID: ippez.robert1 Email: [email protected]