[ISSUE #582] Add jdk11 compile/test in ci #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da796b8
to
48347ca
Compare
|
LGTM |
ruanwenjun
commented
Dec 10, 2021
.github/workflows/ci.yml
Outdated
| @@ -64,7 +64,10 @@ jobs: | |||
|
|
|||
| - name: Build | |||
| # skip check here, since we use Checkstyle task to check the added file | |||
There was a problem hiding this comment.
Yes, We don't use the default check task, since in the current project there are some old code doesn't meet the checkstyle rule. And use a single task to check the changed files.
Has changed the comments here, please review again.
48347ca
to
66d7dbe
Compare
vongosling
reviewed
Dec 10, 2021
| license-check: | ||
| name: License Check | ||
| license-header-check: | ||
| name: License header Check |
There was a problem hiding this comment.
Would you like to help to change the uses repo to main, like here, https://github.com/marketplace/actions/license-eye
vongosling
approved these changes
Dec 10, 2021
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
[ISSUE #582] Add jdk11 compile/test in ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #582, #422