[ISSUE #4845] Apply dependency management to grpcVersion and protobufVersion.
#4988
+38
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Jun 12, 2024
Pil0tXia
changed the title
grpcVersion and protobufVersion.
Pil0tXia
reviewed
Jun 13, 2024
Pil0tXia
added
the
waiting for contributor
Pil0tXia
reviewed
Jun 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4988 +/- ##
=========================================
Coverage 15.64% 15.64%
Complexity 1777 1777
=========================================
Files 1001 1001
Lines 33777 33777
Branches 2917 2917
=========================================
Hits 5284 5284
Misses 27975 27975
Partials 518 518 ☔ View full report in Codecov by Sentry. |
Pil0tXia
reviewed
Jun 19, 2024
build.gradle
Outdated
Comment on lines
657
to
659
| def opentelemetryVersion = '1.36.0' | ||
| def cloudeventsVersion = '3.0.0' | ||
| def cloudeventsVersion = '2.5.0' | ||
| def curatorVersion = '5.7.0' |
build.gradle
Outdated
Comment on lines
757
to
763
| dependency "org.springframework.boot:spring-boot-starter-jetty:2.7.18" | ||
|
|
||
| dependency "com.google.protobuf:protobuf-java-util:${protobufVersion}" | ||
| dependency "com.google.protobuf:protobuf-java:${protobufVersion}" | ||
| dependency "com.google.protobuf:protoc:${protocVersion}" | ||
|
|
||
| dependency "com.mysql:mysql-connector-j:8.4.0" |
There was a problem hiding this comment.
The google.protobuf dependencies should be placed after the grpc dependencies. The same as the protobufVersion var.
Comment on lines
27
to
29
| def protobufVersion = '3.25.3' | ||
| def protocVersion = protobufVersion | ||
|
|
There was a problem hiding this comment.
Redundant protobufVersion field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4845
Previous PR: #4876
Motivation
update grpc version and protobuf version
Modifications
Describe the modifications you've done.
Documentation