Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][ISSUE #482]Support eventmesh server plugin #487

Closed

Conversation

ruanwenjun
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021

Codecov Report

Merging #487 (e124036) into develop (106ca96) will increase coverage by 1.00%.
The diff coverage is 11.67%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #487      +/-   ##
=============================================
+ Coverage      10.42%   11.43%   +1.00%     
- Complexity       328      337       +9     
=============================================
  Files            241      240       -1     
  Lines          11737    11700      -37     
  Branches        1001      982      -19     
=============================================
+ Hits            1224     1338     +114     
+ Misses         10411    10263     -148     
+ Partials         102       99       -3     
Impacted Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 0.00% <0.00%> (ø)
...he/eventmesh/common/EventMeshRuntimeException.java 0.00% <0.00%> (ø)
...e/eventmesh/common/config/CommonConfiguration.java 0.00% <0.00%> (-83.83%) ⬇️
...ache/eventmesh/common/config/EventMeshVersion.java 0.00% <ø> (ø)
...java/org/apache/eventmesh/common/utils/IPUtil.java 46.05% <ø> (ø)
...e/eventmesh/common/utils/InnerCollectionUtils.java 0.00% <0.00%> (ø)
...ache/eventmesh/common/utils/RandomStringUtils.java 0.00% <0.00%> (ø)
.../org/apache/eventmesh/common/utils/ThreadUtil.java 28.57% <0.00%> (ø)
...nector/rocketmq/consumer/RocketMQConsumerImpl.java 0.00% <0.00%> (ø)
...nector/rocketmq/producer/RocketMQProducerImpl.java 0.00% <0.00%> (ø)
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106ca96...e124036. Read the comment docs.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addProtocolPlugin branch 5 times, most recently from 198e8e0 to 84bb2ff Compare August 9, 2021 12:05
@Jackzeng1224
Copy link

@ruanwenjun hello,There was a problem when verifying the version. See the picture. I have added dependencies for related configurations.
image
image

@ruanwenjun
Copy link
Member Author

ruanwenjun commented Aug 10, 2021

@Jackzeng1224 I can run the test in AsyncPublishInstance success, could you please clean the local cache class, and test again.
image

@Jackzeng1224
Copy link

@Jackzeng1224 I can run the test in AsyncPublishInstance success, could you please clean the local cache class, and test again.
image

@ruanwenjun Every time I work on a new project. Now the newly downloaded project has a new problem.
image

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 This may be caused by the TCP Server plugin have not been installed.
You can add this dependency in build.gradle, or remove the tcp in eventmesh.yml.

implementation project(":eventmesh-protocol-plugin:eventmesh-protocol-tcp")

I will optimize this tonignt

@Jackzeng1224
Copy link

@Jackzeng1224 This may be caused by the TCP Server plugin have not been installed.
You can add this dependency in build.gradle, or remove the tcp in eventmesh.yml.

implementation project(":eventmesh-protocol-plugin:eventmesh-protocol-tcp")

I will optimize this tonignt

ok.I add it and try.
I have a question.Why can't I configure one separately? If there are 3 or 4 ways, but I only want to use one.
image

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 Of course you can. You can config use which plugin in eventmesh.yml.
You can remove the tcp and then you can just use http plugin
image

@Jackzeng1224
Copy link

@Jackzeng1224 Of course you can. You can config use which plugin in eventmesh.yml.
You can remove the tcp and then you can just use http plugin
image

ok.I got it.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addProtocolPlugin branch 2 times, most recently from 08da854 to aaf9835 Compare August 14, 2021 03:53
@Jackzeng1224
Copy link

@ruanwenjun hello, Has this protocol adapter plugin been submitted?

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 Yes, I have rebased the latest code.

@Jackzeng1224
Copy link

@Jackzeng1224 Yes, I have rebased the latest code.

OK.

@Jackzeng1224
Copy link

@ruanwenjun
hello. I tried the tcp plugin mode, cannot find the protocol plugin: tcp.
image
image

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 When you add the dependency in build.gradle, you need to refresh the gradle.
And you can also use ./gradlew clean jar dist to install the plugins.

@Jackzeng1224
Copy link

@Jackzeng1224 When you add the dependency in build.gradle, you need to refresh the gradle.
And you can also use ./gradlew clean jar dist to install the plugins.

ok.I will try again.

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 Do you meet any other problem?

@Jackzeng1224
Copy link

@Jackzeng1224 Do you meet any other problem?

Not yet, the functions can be used normally.

@ruanwenjun
Copy link
Member Author

@Jackzeng1224 Thanks for your kind assistance.

*/

dependencies {
api project(":eventmesh-connector-plugin:eventmesh-connector-api")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two dependencies connector-api and registry-api may be change to ":eventmesh-spi" and ":eventmesh-common"


dependencies {
api project(":eventmesh-protocol-plugin:eventmesh-protocol-api")
api project(":eventmesh-security-plugin:eventmesh-security-api")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we split the security plugin from the http protocol , integrate the plugin on runtime

@xwm1992
Copy link
Contributor

xwm1992 commented Aug 30, 2021

this pr current implementation just separate the server to http server plugin and tcp server plugin maybe call server plugin more appropriate, not protocol plugin. I think we need to design a protocol layer api(tcp and http) which is depended by server plugin, to make the protocol layer more extensible.

@ruanwenjun ruanwenjun changed the title [ISSUE #482]Support protocol adaptor plugin [WIP][ISSUE #482]Support protocol adaptor plugin Sep 1, 2021
@ruanwenjun ruanwenjun changed the title [WIP][ISSUE #482]Support protocol adaptor plugin [WIP][ISSUE #482]Support eventmesh server plugin Sep 2, 2021
@ruanwenjun
Copy link
Member Author

@xwm1992 @Jackzeng1224 Yes, the module has been renamed to eventmesh-server-plugin, and I will try to design the protocol plugin, maybe this pr can be merged, since the other pr will be blocked.

@qqeasonchen
Copy link
Contributor

I think protocol adapter is more needed.

@ruanwenjun
Copy link
Member Author

Closed by too many conflicts, if this is needed, we can submit a new pr.

@ruanwenjun ruanwenjun closed this Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants