-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][ISSUE #482]Support eventmesh server plugin #487
[WIP][ISSUE #482]Support eventmesh server plugin #487
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #487 +/- ##
=============================================
+ Coverage 10.42% 11.43% +1.00%
- Complexity 328 337 +9
=============================================
Files 241 240 -1
Lines 11737 11700 -37
Branches 1001 982 -19
=============================================
+ Hits 1224 1338 +114
+ Misses 10411 10263 -148
+ Partials 102 99 -3
Continue to review full report at Codecov.
|
198e8e0
to
84bb2ff
Compare
@ruanwenjun hello,There was a problem when verifying the version. See the picture. I have added dependencies for related configurations. |
@Jackzeng1224 I can run the test in AsyncPublishInstance success, could you please clean the local cache class, and test again. |
aaaff76
to
ea423f2
Compare
@ruanwenjun Every time I work on a new project. Now the newly downloaded project has a new problem. |
@Jackzeng1224 This may be caused by the TCP Server plugin have not been installed.
I will optimize this tonignt |
ok.I add it and try. |
@Jackzeng1224 Of course you can. You can config use which plugin in eventmesh.yml. |
ok.I got it. |
08da854
to
aaf9835
Compare
@ruanwenjun hello, Has this protocol adapter plugin been submitted? |
@Jackzeng1224 Yes, I have rebased the latest code. |
OK. |
@ruanwenjun |
@Jackzeng1224 When you add the dependency in |
ok.I will try again. |
@Jackzeng1224 Do you meet any other problem? |
Not yet, the functions can be used normally. |
@Jackzeng1224 Thanks for your kind assistance. |
aaf9835
to
53feb58
Compare
53feb58
to
29b2355
Compare
eventmesh-protocol-plugin/eventmesh-protocol-tcp/src/main/resources/eventmesh-protocol-tcp.yml
Outdated
Show resolved
Hide resolved
*/ | ||
|
||
dependencies { | ||
api project(":eventmesh-connector-plugin:eventmesh-connector-api") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two dependencies connector-api
and registry-api
may be change to ":eventmesh-spi"
and ":eventmesh-common"
|
||
dependencies { | ||
api project(":eventmesh-protocol-plugin:eventmesh-protocol-api") | ||
api project(":eventmesh-security-plugin:eventmesh-security-api") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we split the security plugin from the http protocol , integrate the plugin on runtime
this pr current implementation just separate the server to |
@xwm1992 @Jackzeng1224 Yes, the module has been renamed to eventmesh-server-plugin, and I will try to design the protocol plugin, maybe this pr can be merged, since the other pr will be blocked. |
I think protocol adapter is more needed. |
Closed by too many conflicts, if this is needed, we can submit a new pr. |
No description provided.