[ISSUE #4712]Enhancement for NacosMetaService #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
requested changes
Jan 3, 2024
| shutdownNacosService(); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:WhitespaceAround") |
There was a problem hiding this comment.
Why CheckStyle warnings should be suppressed?
| @@ -216,13 +216,25 @@ public void shutdown() throws MetaException { | |||
| if (!startStatus.compareAndSet(true, false)) { | |||
| return; | |||
| } | |||
| shutdownNacosService(); | |||
There was a problem hiding this comment.
I think this method can be inlined. The shutdown() interface is used to shutdown Nacos, and there is no need to extract a separate method specifically for closing Nacos.
There was a problem hiding this comment.
please review again, thanks.
Pil0tXia
requested changes
Jan 3, 2024
Comment on lines
233
to
236
| } | ||
|
|
||
|
|
||
| @Override |
pandaapo
approved these changes
Jan 3, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4713 +/- ##
=========================================
Coverage 17.39% 17.40%
Complexity 1759 1759
=========================================
Files 797 797
Lines 29850 29856 +6
Branches 2579 2579
=========================================
+ Hits 5192 5195 +3
- Misses 24177 24180 +3
Partials 481 481 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4712.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation