-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3928] Optimize http protocol log print #3930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3930 +/- ##
============================================
+ Coverage 14.22% 14.24% +0.01%
Complexity 1328 1328
============================================
Files 580 580
Lines 28856 28825 -31
Branches 2792 2786 -6
============================================
Hits 4105 4105
+ Misses 24361 24330 -31
Partials 390 390
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@mxsm please fix the conflict. |
@xwm1992 PTAL~ I have fixed it |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3930 +/- ##
============================================
+ Coverage 14.22% 14.24% +0.01%
Complexity 1328 1328
============================================
Files 580 580
Lines 28856 28825 -31
Branches 2792 2786 -6
============================================
Hits 4105 4105
+ Misses 24361 24330 -31
Partials 390 390 ☔ View full report in Codecov by Sentry. |
if (log.isWarnEnabled()) { | ||
log.warn("FinishSpanWithException with map:{}", map); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask that why logging level should be upgraded to warn
here?
By the way, log.isWarnEnabled()
is redundant~
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3928
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Optimize http protocol log print
Documentation