Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3928] Optimize http protocol log print #3930

Closed
wants to merge 2 commits into from

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented May 14, 2023

Fixes #3928

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Optimize http protocol log print

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3930 (8d79523) into master (fb144bb) will increase coverage by 0.01%.
The diff coverage is 5.26%.

❗ Current head 8d79523 differs from pull request most recent head 663d4dc. Consider uploading reports for the commit 663d4dc to get more accurate results

@@             Coverage Diff              @@
##             master    #3930      +/-   ##
============================================
+ Coverage     14.22%   14.24%   +0.01%     
  Complexity     1328     1328              
============================================
  Files           580      580              
  Lines         28856    28825      -31     
  Branches       2792     2786       -6     
============================================
  Hits           4105     4105              
+ Misses        24361    24330      -31     
  Partials        390      390              
Impacted Files Coverage Δ
.../org/apache/eventmesh/runtime/util/TraceUtils.java 0.00% <0.00%> (ø)
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 1.22% <6.45%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992
Copy link
Contributor

xwm1992 commented May 25, 2023

@mxsm please fix the conflict.

@mxsm
Copy link
Member Author

mxsm commented Jun 7, 2023

@xwm1992 PTAL~ I have fixed it

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 36 lines in your changes missing coverage. Please review.

Project coverage is 14.24%. Comparing base (fb144bb) to head (8d79523).
Report is 514 commits behind head on master.

Current head 8d79523 differs from pull request most recent head 663d4dc

Please upload reports for the commit 663d4dc to get more accurate results.

Files Patch % Lines
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 6.45% 29 Missing ⚠️
.../org/apache/eventmesh/runtime/util/TraceUtils.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3930      +/-   ##
============================================
+ Coverage     14.22%   14.24%   +0.01%     
  Complexity     1328     1328              
============================================
  Files           580      580              
  Lines         28856    28825      -31     
  Branches       2792     2786       -6     
============================================
  Hits           4105     4105              
+ Misses        24361    24330      -31     
  Partials        390      390              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +115 to +117
if (log.isWarnEnabled()) {
log.warn("FinishSpanWithException with map:{}", map);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask that why logging level should be upgraded to warn here?

By the way, log.isWarnEnabled() is redundant~

@Pil0tXia Pil0tXia changed the title [ISSUE #3928]Optimize http protocol log print [ISSUE #3928] Optimize http protocol log print Apr 23, 2024
@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Jun 22, 2024
@mxsm mxsm closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize http protocol log print
4 participants