-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3888]Optimize xml file License #3890
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
=========================================
Coverage 13.93% 13.93%
Complexity 1291 1291
=========================================
Files 570 570
Lines 28847 28847
Branches 2811 2811
=========================================
Hits 4019 4019
Misses 24455 24455
Partials 373 373 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Conflict resolution, please. |
Licensed to the Apache Software Foundation (ASF) under one or more | ||
contributor license agreements. See the NOTICE file distributed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ~
should be removed, not just the ~
, to maintain the correct two-space indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
~
should be removed, not just the~
, to maintain the correct two-space indentation.
I will do later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both styles are OK. If ~
is auto-generated, it is fine to keep it. Nevertheless, some projects may not use ~
, for example fineract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the apache/skywalking-eyes
action is considered valid for both license headers with and without ~
. However it adds ~
when auto-generating. Considering that all xml license headers in EventMesh now have ~
, we can unify having ~
.
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3890 +/- ##
=========================================
Coverage 13.93% 13.93%
Complexity 1291 1291
=========================================
Files 570 570
Lines 28847 28847
Branches 2811 2811
=========================================
Hits 4019 4019
Misses 24455 24455
Partials 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mxsm Please fix conflicts. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3888
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Documentation