Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3880] Optimize ClientSessionGroupMapping #3881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented May 7, 2023

Fixes #3880

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

  • Optimize ClientSessionGroupMapping
  • change ConcurrentHashMap<InetSocketAddress, Session> to ConcurrentHashMap<String, Session>

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3881 (214e6e1) into master (e1e9aca) will increase coverage by 0.00%.
The diff coverage is 1.96%.

❗ Current head 214e6e1 differs from pull request most recent head 0364e2d. Consider uploading reports for the commit 0364e2d to get more accurate results

@@            Coverage Diff            @@
##             master    #3881   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28833   -14     
  Branches       2811     2809    -2     
=========================================
  Hits           4019     4019           
+ Misses        24455    24441   -14     
  Partials        373      373           
Impacted Files Coverage Δ
...e/admin/handler/RedirectClientByIpPortHandler.java 31.37% <0.00%> (ø)
...dmin/handler/RedirectClientBySubSystemHandler.java 9.09% <0.00%> (ø)
.../runtime/admin/handler/RejectAllClientHandler.java 12.50% <0.00%> (ø)
...ime/admin/handler/RejectClientByIpPortHandler.java 9.30% <0.00%> (ø)
.../admin/handler/RejectClientBySubSystemHandler.java 8.33% <0.00%> (ø)
...ntime/admin/handler/ShowClientBySystemHandler.java 15.38% <0.00%> (ø)
...tmesh/runtime/admin/handler/ShowClientHandler.java 14.81% <0.00%> (ø)
...ntmesh/runtime/admin/handler/TCPClientHandler.java 4.34% <0.00%> (+0.09%) ⬆️
.../runtime/admin/request/DeleteTCPClientRequest.java 0.00% <0.00%> (ø)
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.81% <0.00%> (+0.03%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.96078% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 13.93%. Comparing base (e1e9aca) to head (214e6e1).
Report is 502 commits behind head on master.

❗ Current head 214e6e1 differs from pull request most recent head 0364e2d. Consider uploading reports for the commit 0364e2d to get more accurate results

Files Patch % Lines
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.00% 24 Missing ⚠️
...ntime/core/protocol/tcp/client/task/HelloTask.java 0.00% 7 Missing ⚠️
...ime/admin/handler/RejectClientByIpPortHandler.java 0.00% 5 Missing ⚠️
...ntmesh/runtime/admin/handler/TCPClientHandler.java 0.00% 4 Missing ⚠️
.../runtime/admin/handler/RejectAllClientHandler.java 0.00% 2 Missing ⚠️
.../runtime/admin/request/DeleteTCPClientRequest.java 0.00% 2 Missing ⚠️
...e/admin/handler/RedirectClientByIpPortHandler.java 0.00% 1 Missing ⚠️
...dmin/handler/RedirectClientBySubSystemHandler.java 0.00% 1 Missing ⚠️
.../admin/handler/RejectClientBySubSystemHandler.java 0.00% 1 Missing ⚠️
...ntime/admin/handler/ShowClientBySystemHandler.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3881   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28833   -14     
  Branches       2811     2809    -2     
=========================================
  Hits           4019     4019           
+ Misses        24455    24441   -14     
  Partials        373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 57 to 59

private final ConcurrentHashMap<InetSocketAddress, Session> sessionTable = new ConcurrentHashMap<>();
private final ConcurrentHashMap<String/*ip:port*/, Session> sessionTable = new ConcurrentHashMap<>(64);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask that what's the main benefit of changing InetSocketAddress to String?

@Pil0tXia Pil0tXia changed the title [ISSUE #3880]Optimize ClientSessionGroupMapping [ISSUE #3880] Optimize ClientSessionGroupMapping Apr 23, 2024
@github-actions github-actions bot removed the Stale label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize ClientSessionGroupMapping
3 participants