-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3880] Optimize ClientSessionGroupMapping #3881
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3881 +/- ##
=========================================
Coverage 13.93% 13.93%
Complexity 1291 1291
=========================================
Files 570 570
Lines 28847 28833 -14
Branches 2811 2809 -2
=========================================
Hits 4019 4019
+ Misses 24455 24441 -14
Partials 373 373
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3881 +/- ##
=========================================
Coverage 13.93% 13.93%
Complexity 1291 1291
=========================================
Files 570 570
Lines 28847 28833 -14
Branches 2811 2809 -2
=========================================
Hits 4019 4019
+ Misses 24455 24441 -14
Partials 373 373 ☔ View full report in Codecov by Sentry. |
|
||
private final ConcurrentHashMap<InetSocketAddress, Session> sessionTable = new ConcurrentHashMap<>(); | ||
private final ConcurrentHashMap<String/*ip:port*/, Session> sessionTable = new ConcurrentHashMap<>(64); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask that what's the main benefit of changing InetSocketAddress
to String
?
Fixes #3880
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Documentation