Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3338] Add OpenmessageGrpcProduder implemention in sdk-java #3862

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented May 3, 2023

Fixes #3338

Motivation

  • Add OpenmessageGrpcProduder implemention in sdk-java

Modifications

  • Add OpenmessageGrpcProduder implemention in sdk-java

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #3862 (6406574) into master (91aab4d) will increase coverage by 0.19%.
The diff coverage is 53.10%.

❗ Current head 6406574 differs from pull request most recent head dabadff. Consider uploading reports for the commit dabadff to get more accurate results

@@             Coverage Diff              @@
##             master    #3862      +/-   ##
============================================
+ Coverage     13.77%   13.96%   +0.19%     
- Complexity     1290     1307      +17     
============================================
  Files           571      572       +1     
  Lines         29129    29267     +138     
  Branches       2837     2863      +26     
============================================
+ Hits           4012     4087      +75     
- Misses        24745    24797      +52     
- Partials        372      383      +11     
Impacted Files Coverage Δ
...tmesh/common/protocol/grpc/common/ProtocolKey.java 0.00% <ø> (ø)
...mesh/storage/kafka/consumer/KafkaConsumerImpl.java 9.09% <ø> (ø)
...eventmesh/storage/pravega/PravegaConsumerImpl.java 16.66% <ø> (ø)
...standalone/consumer/StandaloneConsumerAdaptor.java 0.00% <0.00%> (ø)
...che/eventmesh/trace/jaeger/JaegerTraceService.java 60.00% <ø> (ø)
...eventmesh/trace/pinpoint/PinpointTraceService.java 52.17% <ø> (ø)
...che/eventmesh/trace/zipkin/ZipkinTraceService.java 55.12% <ø> (ø)
...sh/client/grpc/producer/EventMeshGrpcProducer.java 40.42% <10.00%> (-5.73%) ⬇️
...h/client/grpc/producer/OpenMessageGrpProducer.java 13.63% <13.63%> (ø)
...sh/storage/pulsar/consumer/PulsarConsumerImpl.java 5.88% <25.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 53.10345% with 68 lines in your changes missing coverage. Please review.

Project coverage is 13.96%. Comparing base (91aab4d) to head (6406574).
Report is 638 commits behind head on master.

Current head 6406574 differs from pull request most recent head dabadff

Please upload reports for the commit dabadff to get more accurate results.

Files Patch % Lines
...h/client/grpc/producer/OpenMessageGrpProducer.java 13.63% 38 Missing ⚠️
...ventmesh/client/grpc/util/EventMeshClientUtil.java 80.95% 6 Missing and 10 partials ⚠️
...sh/client/grpc/producer/EventMeshGrpcProducer.java 10.00% 9 Missing ⚠️
...sh/storage/pulsar/consumer/PulsarConsumerImpl.java 25.00% 3 Missing ⚠️
.../storage/knative/consumer/KnativeConsumerImpl.java 50.00% 1 Missing ⚠️
...standalone/consumer/StandaloneConsumerAdaptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3862      +/-   ##
============================================
+ Coverage     13.77%   13.96%   +0.19%     
- Complexity     1290     1307      +17     
============================================
  Files           571      572       +1     
  Lines         29129    29267     +138     
  Branches       2837     2863      +26     
============================================
+ Hits           4012     4087      +75     
- Misses        24745    24797      +52     
- Partials        372      383      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia Pil0tXia changed the title [ISSUE #3338]Add OpenmessageGrpcProduder implemention in sdk-java [ISSUE #3338] Add OpenmessageGrpcProduder implemention in sdk-java Apr 23, 2024
Comment on lines +101 to +102

SimpleMessage simpleMessage = EventMeshClientUtil.buildSimpleMessage(message, clientConfig, PROTOCOL_TYPE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SimpleMessage has been renamed. Please resolve conflicts~

@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 22, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]Add OpenmessageGrpcProduder implemention in sdk-java
3 participants