[ISSUE #3402]"getExtension()" can return null.[Trace] #3632

harshithasudhakar · 2023-04-05T10:15:57Z

Fixes #3402

Motivation

Using requireNonNull() to check incoming references, can control the point in time when the exception will be thrown.

Modifications

Included "Object.requireNonNull()"

Documentation

Does this pull request introduce a new feature? (yes / no)
No
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
No

Included "Object.requireNonNull()"

Alonexc

LGTM

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java

mxsm

Hi @harshithasudhakar CI not pass, Please check it

harshithasudhakar · 2023-04-06T15:55:53Z

Hi @harshithasudhakar CI not pass, Please check it

I have rectified the issue now.

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java

Alonexc

LGTM

pandaapo

The judgment of ternary operation ensures that cloudEvent. getExtension (entry) cannot return null. Objects.requireNonNull() is redundant. @harshithasudhakar @xwm1992

pandaapo · 2023-05-19T23:39:54Z

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java

@@ -140,7 +141,7 @@ public Span addTraceInfoToSpan(Span span, CloudEvent cloudEvent) {
 }

 for (String entry : cloudEvent.getExtensionNames()) {
- span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : cloudEvent.getExtension(entry).toString());
+ span.setAttribute(entry, cloudEvent.getExtension(entry) != null ? cloudEvent.getExtension(entry).toString() : "");
 }


Now you see there is no problem with the original code here. The other one is in the same situation.
In conclusion, this issue should not be posted. So let's wait the maintainer to make the final decision.

scwlkq · 2023-10-22T15:53:24Z

@pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？

hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?

mxsm · 2023-10-22T15:57:15Z

@pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？

hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?

@scwlkq Hi you can try this issue #4502 ,If you are interested, I can assign this issue to you.

codecov · 2023-10-22T18:40:29Z

Codecov Report

Merging #3632 (97c99de) into master (d3f688d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 97c99de differs from pull request most recent head ab4d13a. Consider uploading reports for the commit ab4d13a to get more accurate results

@@             Coverage Diff              @@
##             master    #3632      +/-   ##
============================================
- Coverage     15.47%   15.47%   -0.01%     
  Complexity     1452     1452              
============================================
  Files           691      691              
  Lines         28106    28112       +6     
  Branches       2626     2629       +3     
============================================
  Hits           4349     4349              
- Misses        23312    23318       +6     
  Partials        445      445

Files	Coverage Δ
...java/org/apache/eventmesh/runtime/trace/Trace.java	`0.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pandaapo · 2023-10-23T04:04:06Z

#3632 (review)

#3632 (comment)

What is the significance of these modifications in this PR? @mxsm

Pil0tXia · 2023-10-24T09:07:11Z

What is the significance of these modifications in this PR? @mxsm

@pandaapo In your screenshots, it seems little changes have been made indeed.

Pil0tXia · 2024-01-09T14:13:16Z

Any progress can be made in this PR?

github-actions · 2024-04-22T18:32:11Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

codecov-commenter · 2024-04-22T18:32:20Z

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.47%. Comparing base (d3f688d) to head (97c99de).
Report is 236 commits behind head on master.

❗ Current head 97c99de differs from pull request most recent head ab4d13a

Please upload reports for the commit ab4d13a to get more accurate results.

Files	Patch %	Lines
...java/org/apache/eventmesh/runtime/trace/Trace.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3632      +/-   ##
============================================
- Coverage     15.47%   15.47%   -0.01%     
  Complexity     1452     1452              
============================================
  Files           691      691              
  Lines         28106    28112       +6     
  Branches       2626     2629       +3     
============================================
  Hits           4349     4349              
- Misses        23312    23318       +6     
  Partials        445      445

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pil0tXia · 2024-06-12T18:20:10Z

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java

 Span span = context != null ? context.get(SpanKey.SERVER_KEY) : null;
- return addTraceInfoToSpan(span, cloudEvent);
+
+ if (span == null) {
+ log.warn("span is null when finishSpan");
+ return null;
+ }
+
+ //add trace info
+ for (String entry : cloudEvent.getExtensionNames()) {
+ span.setAttribute(entry, cloudEvent.getExtension(entry) == null ? "" : Objects.requireNonNull(cloudEvent.getExtension(entry)).toString());
+ }
+ return span;


Why do we need to inline the addTraceInfoToSpan method here? I think it is enough to add a requireNonNull method in the "add trace info" step of addTraceInfoToSpan method.

I think it is enough to add a requireNonNull method in the "add trace info" step of addTraceInfoToSpan method.

I found that your current suggestion contradicts your previous one (#3632 (comment)). So, why you now think it's needed to add an extra requireNonNull to addTraceInfoToSpan method?

@pandaapo Excuse me for overlooking some folded context earlier. I initially intended to point out that the addTraceInfoToSpan method should not be inlined here. However, it appears that further review is unnecessary as the issue corresponding to this PR is invalid. I will close the issue and label this PR as invalid.

@harshithasudhakar Thank you very much for your contribution. Please feel free to select other valuable issues to work on.

Update Trace.java

da88de9

Included "Object.requireNonNull()"

Alonexc reviewed Apr 6, 2023

View reviewed changes

xwm1992 changed the title ~~[ISSUE#3402]"getExtension()" can return null.[Trace]~~ [ISSUE #3402]"getExtension()" can return null.[Trace] Apr 6, 2023

xwm1992 requested changes Apr 6, 2023

View reviewed changes

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java Outdated Show resolved Hide resolved

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java Outdated Show resolved Hide resolved

mxsm reviewed Apr 6, 2023

View reviewed changes

Update Trace.java

1f8013e

harshithasudhakar requested review from xwm1992 and mxsm April 6, 2023 15:56

Alonexc reviewed Apr 11, 2023

View reviewed changes

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java Outdated Show resolved Hide resolved

Alonexc reviewed Apr 11, 2023

View reviewed changes

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java Outdated Show resolved Hide resolved

Update Trace.java

afcd2eb

harshithasudhakar requested a review from Alonexc April 11, 2023 04:56

Alonexc reviewed Apr 14, 2023

View reviewed changes

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/trace/Trace.java Outdated Show resolved Hide resolved

Update Trace.java

efb436e

harshithasudhakar requested a review from Alonexc April 14, 2023 07:50

Alonexc previously approved these changes Apr 17, 2023

View reviewed changes

pandaapo requested changes May 19, 2023

View reviewed changes

Update Trace.java

d4b209b

harshithasudhakar dismissed Alonexc’s stale review via d4b209b May 19, 2023 18:05

harshithasudhakar requested a review from pandaapo May 19, 2023 18:09

pandaapo reviewed May 19, 2023

View reviewed changes

Merge branch 'master' into patch-5

ab4d13a

mxsm approved these changes Oct 23, 2023

View reviewed changes

github-actions bot added the Stale label Apr 22, 2024

github-actions bot removed the Stale label Apr 23, 2024

Pil0tXia requested changes Jun 12, 2024

View reviewed changes

Pil0tXia mentioned this pull request Jun 12, 2024

[Enhancement] "getExtension()" can return null.[Trace] #3402

Closed

2 tasks

Pil0tXia added the invalid This doesn't seem right label Jun 12, 2024

Pil0tXia mentioned this pull request Jun 12, 2024

[ISSUE #3402] Improve Trace class #4987

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #3402]"getExtension()" can return null.[Trace] #3632

[ISSUE #3402]"getExtension()" can return null.[Trace] #3632

harshithasudhakar commented Apr 5, 2023

Alonexc left a comment

mxsm left a comment

harshithasudhakar commented Apr 6, 2023

Alonexc left a comment

pandaapo left a comment •

edited

pandaapo May 19, 2023

scwlkq commented Oct 22, 2023

mxsm commented Oct 22, 2023 •

edited

codecov bot commented Oct 22, 2023 •

edited

pandaapo commented Oct 23, 2023

Pil0tXia commented Oct 24, 2023

Pil0tXia commented Jan 9, 2024

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024 •

edited by codecov bot

Pil0tXia Jun 12, 2024

pandaapo Jun 12, 2024

Pil0tXia Jun 12, 2024 •

edited

[ISSUE #3402]"getExtension()" can return null.[Trace] #3632

Are you sure you want to change the base?

[ISSUE #3402]"getExtension()" can return null.[Trace] #3632

Conversation

harshithasudhakar commented Apr 5, 2023

Motivation

Modifications

Documentation

Alonexc left a comment

Choose a reason for hiding this comment

mxsm left a comment

Choose a reason for hiding this comment

harshithasudhakar commented Apr 6, 2023

Alonexc left a comment

Choose a reason for hiding this comment

pandaapo left a comment • edited

Choose a reason for hiding this comment

pandaapo May 19, 2023

Choose a reason for hiding this comment

scwlkq commented Oct 22, 2023

mxsm commented Oct 22, 2023 • edited

codecov bot commented Oct 22, 2023 • edited

Codecov Report

pandaapo commented Oct 23, 2023

Pil0tXia commented Oct 24, 2023

Pil0tXia commented Jan 9, 2024

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024 • edited by codecov bot

Codecov Report

Pil0tXia Jun 12, 2024

Choose a reason for hiding this comment

pandaapo Jun 12, 2024

Choose a reason for hiding this comment

Pil0tXia Jun 12, 2024 • edited

Choose a reason for hiding this comment

pandaapo left a comment •

edited

mxsm commented Oct 22, 2023 •

edited

codecov bot commented Oct 22, 2023 •

edited

codecov-commenter commented Apr 22, 2024 •

edited by codecov bot

Pil0tXia Jun 12, 2024 •

edited