-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): make graph node draggable in none
and circular
layout
#15428
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
23ae97b
feat(graph): simple layout graph support dragging
kongmoumou 78b2475
test(graph): add simple graph draggable test case
kongmoumou 1d962f6
feat(graph): update circular layout helper function
kongmoumou ae38c73
feat(graph): support draggable for all graph layout ('none' | 'circul…
kongmoumou ebae264
test(graph): add graph draggable test case
kongmoumou 8144dcc
Revert "test(graph): add simple graph draggable test case"
kongmoumou 5f8f0c6
fix(graph): node el check for circular layout
kongmoumou db01e51
fix(graph): remove GraphNode `_fixed` field
kongmoumou 2b1595d
fix(graph): use zrender/vector calculate node layout
kongmoumou 7891815
Merge remote-tracking branch 'upstream/next' into feat-simple-graph-d…
kongmoumou 472e72b
fix: not trigger roam on el's child
kongmoumou 657f379
fix: fix code
kongmoumou aeb66aa
fix: remove useless code
kongmoumou 45a1ebd
fix: store fixed state in layout object
kongmoumou 155364a
fix: use mouse position calculate circular layout
kongmoumou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(graph): support draggable for all graph layout ('none' | 'circul…
…ar' | 'force')
- Loading branch information
commit ae38c73f1bab18bd72c259756fff3e3644ffe731
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a better place to store the
fixed
status rather than the very basic graph structure. In fact,series-graph.node
hasfixed
option. But currently it's only for force layout.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently store in the
fixed
option of nodeModel