fix(markLine): symbolOffset incorrectly marked as mandatory #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
plainheart
approved these changes
Apr 17, 2021
|
Thanks for the review @plainheart - is it ok to merge now? |
I think this should be okay. |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
Btw sorry for not catching this sooner! I meant to test the 5.1.0 release candidate, but I ran out of time before the vote was closed. But anyway, this is mostly a cosmetic issue, so probably not something that requires a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
When upgrading the ECharts dependency in Superset from 5.0.2 to 5.1.0, I noticed that
symbolOffsetinMarkLine1DDataItemOptionis marked as mandatory, while it's optional inMarkLine2DDataItemOption. I believe this parameter can be made optional.Fixed issues
Merging options
Other information