Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Optimize BitList method & Reduce Copy in RouterChain #9369

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Dec 9, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #9369 (c2758dc) into 3.0 (954c715) will decrease coverage by 0.07%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9369      +/-   ##
============================================
- Coverage     65.38%   65.31%   -0.08%     
  Complexity      342      342              
============================================
  Files          1202     1202              
  Lines         51844    51876      +32     
  Branches       7727     7729       +2     
============================================
- Hits          33898    33881      -17     
- Misses        14334    14380      +46     
- Partials       3612     3615       +3     
Impacted Files Coverage Δ
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 69.69% <0.00%> (-1.08%) ⬇️
...bo/rpc/cluster/router/state/StateRouterResult.java 30.23% <0.00%> (-41.99%) ⬇️
...apache/dubbo/rpc/cluster/router/state/BitList.java 89.00% <50.00%> (-1.32%) ⬇️
...pache/dubbo/common/function/ThrowableFunction.java 71.42% <0.00%> (-28.58%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.88% <0.00%> (-5.13%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 79.16% <0.00%> (-4.17%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 69.15% <0.00%> (-2.81%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.95% <0.00%> (-2.41%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 83.52% <0.00%> (-2.36%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 63.28% <0.00%> (-1.94%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 954c715...c2758dc. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 162d1de into apache:3.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants