Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScopeModel Constructor for Config #9314

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #9314 (3eb38b7) into 3.0 (cccd069) will decrease coverage by 0.09%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9314      +/-   ##
============================================
- Coverage     65.28%   65.18%   -0.10%     
  Complexity      342      342              
============================================
  Files          1201     1201              
  Lines         51723    51821      +98     
  Branches       7723     7723              
============================================
+ Hits          33768    33781      +13     
- Misses        14330    14416      +86     
+ Partials       3625     3624       -1     
Impacted Files Coverage Δ
.../org/apache/dubbo/config/AbstractMethodConfig.java 88.23% <0.00%> (-3.61%) ⬇️
...ava/org/apache/dubbo/config/ApplicationConfig.java 85.27% <0.00%> (-1.06%) ⬇️
...va/org/apache/dubbo/config/ConfigCenterConfig.java 89.47% <0.00%> (-1.93%) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 84.09% <0.00%> (-5.07%) ⬇️
...ain/java/org/apache/dubbo/config/MethodConfig.java 83.22% <0.00%> (-1.09%) ⬇️
...ain/java/org/apache/dubbo/config/ModuleConfig.java 64.40% <0.00%> (-5.97%) ⬇️
...in/java/org/apache/dubbo/config/MonitorConfig.java 82.85% <0.00%> (-13.81%) ⬇️
...n/java/org/apache/dubbo/config/ProtocolConfig.java 89.94% <0.00%> (-5.06%) ⬇️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 66.66% <0.00%> (-5.09%) ⬇️
...n/java/org/apache/dubbo/config/RegistryConfig.java 84.96% <0.00%> (-6.17%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccd069...3eb38b7. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 16319c5 into apache:3.0 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants