Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing task failure error message on Overlord caused by MessageBodyWriter not found error on Middle Manager #15412

Merged

Conversation

gargvishesh
Copy link
Contributor

@gargvishesh gargvishesh commented Nov 22, 2023

Fixes missing task failure error message on Overlord.

The error message was missing since TaskManagementResource#assignTask API wasn't annotated with @Produces(MediaType.APPLICATION_JSON) resulting in the response being treated as application/octet-stream, that in turn lead to MessageBodyWriter not found error on the middle manager. The exception is not logged on the middle manager itself since it happens even before entering the assignTask function -- while mapping arg Task -> MSQControllerTask.

Resolution is to add @Produces annotation to TaskManagementResource#assignTask

Updated error message on Overlord:

org.apache.druid.java.util.common.RE: Failed to assign task[query-50594440-9720-451b-b5c1-76a3d3ff6ffe] to worker[localhost:8091]. Response Code[400] and Message[{"error":"Please make sure to load all the necessary extensions and jars with type 'query_controller'. Could not resolve type id 'query_controller' as a subtype of org.apache.druid.indexing.common.task.Task known type ids = [archive, compact, index, index_hadoop, index_kafka, index_parallel, index_realtime, index_realtime_appenderator, index_sub, kill, move, noop, partial_dimension_cardinality, partial_dimension_distribution, partial_index_generate, partial_index_generic_merge, partial_range_index_generate, restore, single_phase_sub_task]\n at [Source: (org.eclipse.jetty.server.HttpInputOverHTTP); line: -1, column: 10]"}]. Retrying...

@gargvishesh gargvishesh changed the title assign-task-missing-error-msg Fix MessageBodyWriter not found issue in middle manager Nov 22, 2023
@gargvishesh gargvishesh changed the title Fix MessageBodyWriter not found issue in middle manager Fix missing task failure error message on Overlord caused by MessageBodyWriter not found error on Middle Manager Nov 22, 2023
@abhishekagarwal87 abhishekagarwal87 merged commit 4ab0b71 into apache:master Nov 24, 2023
78 of 83 checks passed
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
…odyWriter not found error on Middle Manager (apache#15412)

Fixes missing task failure error message on Overlord.

The error message was missing since TaskManagementResource#assignTask API wasn't annotated with @produces(MediaType.APPLICATION_JSON) resulting in the response being treated as application/octet-stream, that in turn lead to MessageBodyWriter not found error on the middle manager. The exception is not logged on the middle manager itself since it happens even before entering the assignTask function -- while mapping arg Task -> MSQControllerTask.
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
…odyWriter not found error on Middle Manager (apache#15412)

Fixes missing task failure error message on Overlord.

The error message was missing since TaskManagementResource#assignTask API wasn't annotated with @produces(MediaType.APPLICATION_JSON) resulting in the response being treated as application/octet-stream, that in turn lead to MessageBodyWriter not found error on the middle manager. The exception is not logged on the middle manager itself since it happens even before entering the assignTask function -- while mapping arg Task -> MSQControllerTask.
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants