Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing readme #15406

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

317brian
Copy link
Contributor

@317brian 317brian commented Nov 20, 2023

This updates the prod section of the release readme for the website steps. Previously, only staging was updated

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@317brian 317brian marked this pull request as ready for review November 20, 2023 21:08
@317brian
Copy link
Contributor Author

317brian commented Nov 20, 2023

@AmatyaAvadhanula and @LakshSingla could you both PTAL? You two did the last two releases, so let me know if there's any other info you wished you would have known while publishing.

Thanks @vtlim for talking through this with me

@LakshSingla
Copy link
Contributor

It would be good to mention the minimum NPM(I think 16+ is to be used) and the Python(3.11 works properly, 3.6 doesn't) version to execute the steps properly.

@abhishekagarwal87 abhishekagarwal87 merged commit eb6b9cb into apache:master Nov 28, 2023
11 checks passed
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
This updates the prod section of the release readme for the website steps. Previously, only staging was updated
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
This updates the prod section of the release readme for the website steps. Previously, only staging was updated
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants