Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add example connection parameters for Java APIs #15345

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[Docs] Add example connection parameters for Java APIs #15345

merged 3 commits into from
Nov 28, 2023

Conversation

vinlee19
Copy link
Contributor

@vinlee19 vinlee19 commented Nov 8, 2023 •
edited
Loading

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekagarwal87 abhishekagarwal87 merged commit b102667 into apache:master Nov 28, 2023
11 checks passed
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
@vinlee19
[Docs] Add example connection parameters for Java APIs (apache#15345)
8bffbaf
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
@vinlee19
[Docs] Add example connection parameters for Java APIs (apache#15345)
cea6f9e
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinlee19 @abhishekagarwal87 @LakshSingla