Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllogictest] Support pg_typeof #5148

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

melgenek
Copy link
Contributor

@melgenek melgenek commented Feb 1, 2023

Which issue does this PR close?

Closes #5147.

Rationale for this change

In sqllogictest tests I could write a query for Datafusion like this one

select arrow_typeof(null and null), arrow_typeof(null or null);

I would like to write the same query for Postgres, so that not only values are checked for compatibility but also types

select pg_typeof(null and null), pg_typeof(null or null);

What changes are included in this PR?

This pr includes handling of regtype results in Postgres sqllogictest client.

Are these changes tested?

Github actions

Are there any user-facing changes?

Sqllogictest only

@github-actions github-actions bot added core Core datafusion crate sqllogictest labels Feb 1, 2023
@alamb
Copy link
Contributor

alamb commented Feb 1, 2023

Thanks @melgenek

@alamb alamb merged commit b6dbb8d into apache:master Feb 1, 2023
@melgenek melgenek deleted the 5147-pg-typeof branch February 1, 2023 22:42
@ursabot
Copy link

ursabot commented Feb 1, 2023

Benchmark runs are scheduled for baseline = 8bae10b and contender = b6dbb8d. b6dbb8d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@melgenek melgenek mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate sqllogictest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sqllogictest] Support pg_typeof for Postgres compatibility tests
3 participants