Bug fix: Empty Record Batch handling #5131
Conversation
There was a problem hiding this comment.
Thank you @mustafasrepo ❤️
Looks like cargo fmt is needed to get CI passing.
| @@ -2385,6 +2385,36 @@ async fn test_window_agg_sort_orderby_reversed_partitionby_reversed_plan() -> Re | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_window_agg_low_cardinality() -> Result<()> { | |||
|
Thanks again! |
|
Benchmark runs are scheduled for baseline = abeb4fe and contender = d59b6dd. d59b6dd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5090.
Rationale for this change
When cardinality of column is low, and target partition is high, we may get empty record batches in
WindowAggExec. In these cases we receive an error as described in the #5090. This PR adds handling for empty batches to fix the bug.What changes are included in this PR?
A simple change to fix the bug.
Are these changes tested?
Yes, new tests are added.
Are there any user-facing changes?
No.