Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard code target_partitions=4 in sqllogictests #5089

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 27, 2023

Which issue does this PR close?

Closes #5082

Rationale for this change

Keeping the test using the same number of cores will make for deterministic tests and avoid variance from system to system when running tests

The fact that there is an error when the target partitions are set to 32 is a separate bug tracked via #5090

What changes are included in this PR?

Hardcode target partitions to 4 for sqllogictest runner

Are these changes tested?

yes by existing tests

Are there any user-facing changes?

No -- this is a test harness only issue

@alamb alamb marked this pull request as ready for review January 27, 2023 15:17
@alamb alamb requested a review from andygrove January 27, 2023 15:17
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 27, 2023
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2023

Filed #5090 for the underlying issue

@alamb alamb merged commit 7d46d55 into apache:master Jan 27, 2023
@ursabot
Copy link

ursabot commented Jan 27, 2023

Benchmark runs are scheduled for baseline = ad3cc24 and contender = 7d46d55. 7d46d55 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/limit_partitions branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pg_compat_window.slt fails when target_partitions >= 32
3 participants