Minor: extract sort col rewrite into its own module, add unit tests #5088
Conversation
| @@ -333,89 +335,6 @@ where | |||
| v.into_iter().map(|expr| expr.rewrite(rewriter)).collect() | |||
| } | |||
|
|
|||
| /// Rewrite sort on aggregate expressions to sort on the column of aggregate output | |||
| /// For example, `max(x)` is written to `col("MAX(x)")` | |||
| pub fn rewrite_sort_cols_by_aggs( | |||
There was a problem hiding this comment.
this PR just moves this code into a new file and adds some tests
|
This PR just move code and add some UT. So I will do a quick-merge. |
|
Benchmark runs are scheduled for baseline = 7673fcc and contender = a321945. a321945 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Related to #4854
Rationale for this change
I want to make the code easier to work with as part of the fix and breaking the PR into smaller parts will help with review
What changes are included in this PR?
No functional change is intended
Are these changes tested?
Yes
Are there any user-facing changes?
No