-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Move test data into datafusion/core/tests/data
#4855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing code and data is really messy. Cleanup them is very nice !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I review this PR carefully to ensure no mistake in this PR.
I'm sure that this PR just include move file and correct the path.
Due to avoid accumulate conflict, I prepare to do merge quick.
Benchmark runs are scheduled for baseline = 71b9bae and contender = 664edea. 664edea is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Thanks @jackwener |
Which issue does this PR close?
Na
Rationale for this change
This is a cleanup I have wanted to do for a while whenever I look in the
datafusion/core/tests
directory and see intermixed data and code, which offends my sense of order🤮
What changes are included in this PR?
Move all
.csv
data filesdatafusion/core/tests/data
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No