Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Move test data into datafusion/core/tests/data #4855

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 8, 2023

Which issue does this PR close?

Na

Rationale for this change

This is a cleanup I have wanted to do for a while whenever I look in the datafusion/core/tests directory and see intermixed data and code, which offends my sense of order

$ ls tests/

aggregate_simple.csv         data/                        join_fuzz.rs                 parquet_exec.rs              sql_integration.rs           user_defined_plan.rs
aggregate_simple_pipe.csv    dataframe.rs                 jsons/                       path_partition.rs            sqllogictests/               window_fuzz.rs
capitalized_example.csv      dataframe_functions.rs       memory_limit.rs              provider_filter_pushdown.rs  statistics.rs
config_from_env.rs           decimal_data.csv             merge_fuzz.rs                row.rs                       tpc-ds/
csv/                         empty.csv                    null_cases.csv               simplification.rs            tpcds_planning.rs
custom_sources.rs            example.csv                  order_spill_fuzz.rs          sort_key_cursor.rs           tpch-csv/
customer.csv                 fifo.rs                      parquet/                     sql/                         user_defined_aggregates.rs

🤮

What changes are included in this PR?

Move all .csv data files datafusion/core/tests/data

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 8, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing code and data is really messy. Cleanup them is very nice !

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review this PR carefully to ensure no mistake in this PR.
I'm sure that this PR just include move file and correct the path.
Due to avoid accumulate conflict, I prepare to do merge quick.

@jackwener jackwener merged commit 664edea into apache:master Jan 9, 2023
@ursabot
Copy link

ursabot commented Jan 9, 2023

Benchmark runs are scheduled for baseline = 71b9bae and contender = 664edea. 664edea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2023

Thanks @jackwener

@alamb alamb deleted the alamb/consolidate_test_data branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants