Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFusion 16.0.0 release prep: Update version + add changelog #4831

Merged
merged 4 commits into from
Jan 7, 2023

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jan 6, 2023

Which issue does this PR close?

Part of #4776

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner labels Jan 6, 2023
@andygrove andygrove marked this pull request as ready for review January 6, 2023 16:15
@andygrove
Copy link
Member Author

I am running into GitHub API rate limits trying to generate the changelog. I will try again later today.

@andygrove
Copy link
Member Author

The number of request that we make increases over time as we add more issues and PRs. I wonder if we have not hit the limit and need to find a new approach to generating the changelog?

When using GITHUB_TOKEN , the rate limit is 1,000 requests per hour per repository. 

@alamb
Copy link
Contributor

alamb commented Jan 6, 2023

I am running into GitHub API rate limits trying to generate the changelog. I will try again later today.

I used to hit these limits too in arrow-rs -- I spent some time tweaking the various settings for changelog generator -- maybe you can port some of that to datafusion?

https://github.com/apache/arrow-rs/blob/master/.github_changelog_generator

The cache and max issues thing I believe I remember being important here:
https://github.com/apache/arrow-rs/blob/master/dev/release/update_change_log.sh#L74-L84

@andygrove
Copy link
Member Author

Thanks @alamb I will look into that. I guess I just got lucky on my latest attempt and managed to generate it.

@andygrove andygrove requested a review from alamb January 6, 2023 23:03
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andygrove

- Fix querying and defining table / view names with period [\#4530](https://github.com/apache/arrow-datafusion/pull/4530) [[sql](https://github.com/apache/arrow-datafusion/labels/sql)] ([alamb](https://github.com/alamb))
- refactor code about `subquery_alias` and `expr-alias`. [\#4451](https://github.com/apache/arrow-datafusion/pull/4451) [[sql](https://github.com/apache/arrow-datafusion/labels/sql)] ([jackwener](https://github.com/jackwener))

**Implemented enhancements:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty epic list

@alamb alamb changed the title DataFusion 16.0.0 release prep DataFusion 16.0.0 release prep: Update version + add changelog Jan 7, 2023
@alamb
Copy link
Contributor

alamb commented Jan 7, 2023

I took the liberty of merging from apache/master to this branch to resolve a conflict

@andygrove andygrove merged commit dcd52ee into apache:master Jan 7, 2023
@andygrove andygrove deleted the datafusion-16 branch January 7, 2023 23:04
@ursabot
Copy link

ursabot commented Jan 7, 2023

Benchmark runs are scheduled for baseline = 3cc607d and contender = dcd52ee. dcd52ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants