refactor code about subquery_alias and expr-alias.
#4451
Conversation
project_with_alias.with_alias.
refactor: cleanup code of `subqueryAlias` and `expr-alias`.
with_alias.subquery_alias and expr-alias.
|
😆After this refactor, I have find reason of #4483 and other. |
There was a problem hiding this comment.
I really like the approach of consolidating how to make aliases . Big 👍 from me -- thank you @jackwener
cc @avantgardnerio and @andygrove
| )? | ||
| .build() | ||
|
|
||
| let new_proj = project(input, expr)?; |
There was a problem hiding this comment.
well that is certainly much nicer
|
Benchmark runs are scheduled for baseline = 394c5ee and contender = 44c20ef. 44c20ef is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #4483
When I was in the process of investigating the reasons for duplicate Projects and duplicate aliases, I find the code of create subquery_alias or expr-alias use multiple method.
After refactor it, we can easily find all code of create
aliasRationale for this change
refactor code about subquery_alias and expr-alias.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?