Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Update SET in cli.md #4098

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[MINOR] Update SET in cli.md #4098

merged 3 commits into from
Nov 4, 2022

Conversation

waitingkuo
Copy link
Contributor

@waitingkuo waitingkuo commented Nov 3, 2022 •
edited
Loading

add SET

Which issue does this PR close?

Rationale for this change

update docs

What changes are included in this PR?

Are there any user-facing changes?

@waitingkuo
Update cli.md
f55c677 
add `SET`
@waitingkuo waitingkuo changed the title Update cli.md [MINOR] Update SET in cli.md Nov 3, 2022
alamb
alamb approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waitingkuo

I think that this PR needs the magic pretter linter run on it

Until the fix for #4100 is merged, clippy will likely fail on this PR as well

@alamb
Copy link
Contributor

alamb commented Nov 3, 2022

I took the liberty of merging up from master to this PR

@alamb alamb merged commit fc669d5 into apache:master Nov 4, 2022
@ursabot
Copy link

ursabot commented Nov 4, 2022

Benchmark runs are scheduled for baseline = 695cedc and contender = fc669d5. fc669d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@waitingkuo @alamb @Dandandan
[MINOR] Update SET in cli.md (apache#4098)
fdedc70 
* Update cli.md

add `SET`

* prettier

Co-authored-by: Andrew Lamb <[email protected]>
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Nov 5, 2022
@waitingkuo @alamb @Ted-Jiang
[MINOR] Update SET in cli.md (apache#4098)
024d543 
* Update cli.md

add `SET`

* prettier

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingkuo @alamb @ursabot