Fix most benchmark query regressions #4037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Oct 30, 2022
Comment on lines
+43
to
+47
| fn decimal_type(_p: u8, _s: u8) -> DataType { | ||
| // TODO use decimal_type(p, s) once Decimal is fully supported | ||
| // https://github.com/apache/arrow-datafusion/issues/3523 | ||
| DataType::Float64 | ||
| } |
There was a problem hiding this comment.
When we're ready to try decimal again, we just need to update this one function
There was a problem hiding this comment.
We could also add a CLI option to switch between float and decimal
tustvold
approved these changes
Oct 30, 2022
Dandandan
approved these changes
Oct 31, 2022
|
Closing this in favor of #4044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4026
Closes #4025
Closes #4023
Rationale for this change
We cannot use decimal types in the benchmark until they are fully implemented. Overflows are causing queries to return very incorrect results and take longer to run because they return too many rows in some cases.
What changes are included in this PR?
Are there any user-facing changes?
No