Fix user-specified ddoc name in Mango #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a Mango index, we allow the user to specify a design document name. This can be of the form "_design/foo" or just "foo", with the expectation that Mango would automatically add the "_design" prefix. This fixes a bug whereby if the user specified "_design/foo", Mango was prefixing this again, creating a design document called "_design/_design/foo".
eiri
approved these changes
Nov 3, 2017
willholley
added a commit
to willholley/couchdb
that referenced
this pull request
May 22, 2018
When creating a Mango index, we allow the user to specify a design document name. This can be of the form "_design/foo" or just "foo", with the expectation that Mango would automatically add the "_design" prefix. This fixes a bug whereby if the user specified "_design/foo", Mango was prefixing this again, creating a design document called "_design/_design/foo".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When creating a Mango index, we allow the user to specify
a design document name. This can be of the form "_design/foo"
or just "foo", with the expectation that Mango would
automatically add the "_design" prefix.
This fixes a bug whereby if the user specified "_design/foo",
Mango was prefixing this again, creating a design document called
"_design/_design/foo".
Testing recommendations
Added a couple of new eunit tests to cover this. To test manually, verify that you can create a mango index using the
"ddoc"field to specify the design document id, with and without a"_design/"prefix.Checklist