Several backports from master #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging in with admin credentials and no user doc is
present, the name was `null`. Example:
`{"ok":true,"name":null,"roles":["_admin"]}`
closes COUCHDB-1356
COUCHDB-2845
CouchDB should return HTTP 400 instead of HTTP 500 response when revision number isn't integer like "foo-bar" as like as it does for completely invalid revisions like "foo". COUCHDB-2375
COUCHDB-2310
- Use lists:member/2 to check if user name is in list - Throw forbidden error if user is authenticated on db membership check - Normalize terminology readers vs members - Make checks more Erlang-ish COUCHDB-2534
janl
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COUCHDB-1356
COUCHDB-1447
COUCHDB-2310
COUCHDB-2375
COUCHDB-2534
COUCHDB-2845